Use correct symbol for minimum int64 value

petere · petere · commit 805f2bb53f95 · 2016-07-17T09:38:23.000-04:00
The old code used SEQ_MINVALUE to get the smallest int64 value.  This
was done as a convenience to avoid having to deal with INT64_IS_BUSTED,
but that is obsolete now.  Also, it is incorrect because the smallest
int64 value is actually SEQ_MINVALUE-1.  Fix by writing out the constant
the long way, as it is done elsewhere in the code.
diff --git a/contrib/btree_gin/btree_gin.c b/contrib/btree_gin/btree_gin.c
@@ -213,10 +213,7 @@ GIN_SUPPORT(int4)
 static Datum
 leftmostvalue_int8(void)
 {
-	/*
-	 * Use sequence's definition to keep compatibility.
-	 */
-	return Int64GetDatum(SEQ_MINVALUE);
+	return Int64GetDatum(-INT64CONST(0x7FFFFFFFFFFFFFFF) - 1);
 }
 static TypeInfo TypeInfo_int8 = {false, leftmostvalue_int8, btint8cmp};
 
@@ -243,10 +240,7 @@ GIN_SUPPORT(float8)
 static Datum
 leftmostvalue_money(void)
 {
-	/*
-	 * Use sequence's definition to keep compatibility.
-	 */
-	return Int64GetDatum(SEQ_MINVALUE);
+	return Int64GetDatum(-INT64CONST(0x7FFFFFFFFFFFFFFF) - 1);
 }
 static TypeInfo TypeInfo_money = {false, leftmostvalue_money, cash_cmp};
 

Original file line number	Diff line number	Diff line change
`@@ -213,10 +213,7 @@ GIN_SUPPORT(int4)`
`213`	`213`	`static Datum`
`214`	`214`	`leftmostvalue_int8(void)`
`215`	`215`	`{`
`216`		`- /*`
`217`		`- * Use sequence's definition to keep compatibility.`
`218`		`- */`
`219`		`- return Int64GetDatum(SEQ_MINVALUE);`
	`216`	`+ return Int64GetDatum(-INT64CONST(0x7FFFFFFFFFFFFFFF) - 1);`
`220`	`217`	`}`
`221`	`218`	`static TypeInfo TypeInfo_int8 = {false, leftmostvalue_int8, btint8cmp};`
`222`	`219`
`@@ -243,10 +240,7 @@ GIN_SUPPORT(float8)`
`243`	`240`	`static Datum`
`244`	`241`	`leftmostvalue_money(void)`
`245`	`242`	`{`
`246`		`- /*`
`247`		`- * Use sequence's definition to keep compatibility.`
`248`		`- */`
`249`		`- return Int64GetDatum(SEQ_MINVALUE);`
	`243`	`+ return Int64GetDatum(-INT64CONST(0x7FFFFFFFFFFFFFFF) - 1);`
`250`	`244`	`}`
`251`	`245`	`static TypeInfo TypeInfo_money = {false, leftmostvalue_money, cash_cmp};`
`252`	`246`