pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.

anarazel · anarazel · commit 82200115e055 · 2019-10-29T22:53:37.000-07:00
The additional newline seems to have accidentally been introduced in 2c03216, in 9.5. The newline is only issued when an FPW is present for the block reference. While there could be an argument that removing the newlines in the back branches could cause a problem for somebody parsing the pg_waldump output, the likelihood of that seems small enough. It seems at least equally likely that the randomness of when newlines are issued causes problems. Author: Andres Freund Discussion: https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.de Backpatch: 9.5, like 2c03216.
diff --git a/src/bin/pg_waldump/pg_waldump.c b/src/bin/pg_waldump/pg_waldump.c
@@ -515,7 +515,7 @@ XLogDumpDisplayRecord(XLogDumpConfig *config, XLogReaderState *record)
 					BKPIMAGE_IS_COMPRESSED)
 				{
 					printf(" (FPW%s); hole: offset: %u, length: %u, "
-						   "compression saved: %u\n",
+						   "compression saved: %u",
 						   XLogRecBlockImageApply(record, block_id) ?
 						   "" : " for WAL verification",
 						   record->blocks[block_id].hole_offset,
@@ -526,7 +526,7 @@ XLogDumpDisplayRecord(XLogDumpConfig *config, XLogReaderState *record)
 				}
 				else
 				{
-					printf(" (FPW%s); hole: offset: %u, length: %u\n",
+					printf(" (FPW%s); hole: offset: %u, length: %u",
 						   XLogRecBlockImageApply(record, block_id) ?
 						   "" : " for WAL verification",
 						   record->blocks[block_id].hole_offset,

Original file line number	Diff line number	Diff line change
`@@ -515,7 +515,7 @@ XLogDumpDisplayRecord(XLogDumpConfig config, XLogReaderState record)`
`515`	`515`	`BKPIMAGE_IS_COMPRESSED)`
`516`	`516`	`{`
`517`	`517`	`printf(" (FPW%s); hole: offset: %u, length: %u, "`
`518`		`- "compression saved: %u\n",`
	`518`	`+ "compression saved: %u",`
`519`	`519`	`XLogRecBlockImageApply(record, block_id) ?`
`520`	`520`	`"" : " for WAL verification",`
`521`	`521`	`record->blocks[block_id].hole_offset,`
`@@ -526,7 +526,7 @@ XLogDumpDisplayRecord(XLogDumpConfig config, XLogReaderState record)`
`526`	`526`	`}`
`527`	`527`	`else`
`528`	`528`	`{`
`529`		`- printf(" (FPW%s); hole: offset: %u, length: %u\n",`
	`529`	`+ printf(" (FPW%s); hole: offset: %u, length: %u",`
`530`	`530`	`XLogRecBlockImageApply(record, block_id) ?`
`531`	`531`	`"" : " for WAL verification",`
`532`	`532`	`record->blocks[block_id].hole_offset,`