Fix quoting of ACL item in table for upgrade binary compatibility checks

michaelpq · michaelpq · commit 82bb97ed63cb · 2021-11-18T12:53:06.000+09:00
Per buildfarm member prion, that runs the regression tests under a role name that uses a hyphen. Issue introduced by 835bcba. Discussion: https://postgr.es/m/YZW4MvzCZ+hQ34vw@paquier.xyz Backpatch-through: 12
diff --git a/src/test/regress/expected/type_sanity.out b/src/test/regress/expected/type_sanity.out
@@ -668,7 +668,7 @@ CREATE TABLE tab_core_types AS SELECT
   'abc'::refcursor,
   '1 2'::int2vector,
   '1 2'::oidvector,
-  format('%s=UC/%s', USER, USER)::aclitem,
+  format('%I=UC/%I', USER, USER)::aclitem AS aclitem,
   'a fat cat sat on a mat and ate a fat rat'::tsvector,
   'fat & rat'::tsquery,
   'a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11'::uuid,
diff --git a/src/test/regress/sql/type_sanity.sql b/src/test/regress/sql/type_sanity.sql
@@ -505,7 +505,7 @@ CREATE TABLE tab_core_types AS SELECT
   'abc'::refcursor,
   '1 2'::int2vector,
   '1 2'::oidvector,
-  format('%s=UC/%s', USER, USER)::aclitem,
+  format('%I=UC/%I', USER, USER)::aclitem AS aclitem,
   'a fat cat sat on a mat and ate a fat rat'::tsvector,
   'fat & rat'::tsquery,
   'a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11'::uuid,
