Skip to content

Commit 8354e7b

Browse files
peterepetere
committed
Remove unused parameters
Remove various unused parameters in pg_dump code. These have all become unused over time or were never used. Discussion: https://www.postgresql.org/message-id/flat/511bb100-f829-ba21-2f10-9f952ec06ead%402ndquadrant.com
1 parent ff28809 commit 8354e7b

File tree

6 files changed

+44
-61
lines changed

6 files changed

+44
-61
lines changed

‎src/bin/pg_dump/dumputils.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -685,7 +685,7 @@ AddAcl(PQExpBuffer aclbuf, const char *keyword, const char *subname)
685685
* keep this file free of assumptions about how to deal with SQL errors.)
686686
*/
687687
void
688-
buildShSecLabelQuery(PGconn *conn, const char *catalog_name, Oid objectId,
688+
buildShSecLabelQuery(const char *catalog_name, Oid objectId,
689689
PQExpBuffer sql)
690690
{
691691
appendPQExpBuffer(sql,

‎src/bin/pg_dump/dumputils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ extern bool buildDefaultACLCommands(const char *type, const char *nspname,
4646
const char *owner,
4747
int remoteVersion,
4848
PQExpBuffer sql);
49-
extern void buildShSecLabelQuery(PGconn *conn, const char *catalog_name,
49+
extern void buildShSecLabelQuery(const char *catalog_name,
5050
Oid objectId, PQExpBuffer sql);
5151
extern void emitShSecLabels(PGconn *conn, PGresult *res,
5252
PQExpBuffer buffer, const char *objtype, const char *objname);

‎src/bin/pg_dump/pg_backup_archiver.c

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ typedef struct _parallelReadyList
7070
static ArchiveHandle *_allocAH(const char *FileSpec, const ArchiveFormat fmt,
7171
const int compression, bool dosync, ArchiveMode mode,
7272
SetupWorkerPtrType setupWorkerPtr);
73-
static void _getObjectDescription(PQExpBuffer buf, TocEntry *te,
74-
ArchiveHandle *AH);
73+
static void _getObjectDescription(PQExpBuffer buf, TocEntry *te);
7574
static void _printTocEntry(ArchiveHandle *AH, TocEntry *te, bool isData);
7675
static char *sanitize_line(const char *str, bool want_hyphen);
7776
static void _doSetFixedOutputState(ArchiveHandle *AH);
@@ -91,7 +90,7 @@ static bool _tocEntryIsACL(TocEntry *te);
9190
static void _disableTriggersIfNecessary(ArchiveHandle *AH, TocEntry *te);
9291
static void _enableTriggersIfNecessary(ArchiveHandle *AH, TocEntry *te);
9392
static void buildTocEntryArrays(ArchiveHandle *AH);
94-
static void _moveBefore(ArchiveHandle *AH, TocEntry *pos, TocEntry *te);
93+
static void _moveBefore(TocEntry *pos, TocEntry *te);
9594
static int _discoverArchiveFormat(ArchiveHandle *AH);
9695

9796
static int RestoringToDB(ArchiveHandle *AH);
@@ -121,8 +120,7 @@ static int TocEntrySizeCompare(const void *p1, const void *p2);
121120
static void move_to_ready_list(TocEntry *pending_list,
122121
ParallelReadyList *ready_list,
123122
RestorePass pass);
124-
static TocEntry *pop_next_work_item(ArchiveHandle *AH,
125-
ParallelReadyList *ready_list,
123+
static TocEntry *pop_next_work_item(ParallelReadyList *ready_list,
126124
ParallelState *pstate);
127125
static void mark_dump_job_done(ArchiveHandle *AH,
128126
TocEntry *te,
@@ -1442,7 +1440,7 @@ SortTocFromFile(Archive *AHX)
14421440
* side-effects on the order in which restorable items actually get
14431441
* restored.
14441442
*/
1445-
_moveBefore(AH, AH->toc, te);
1443+
_moveBefore(AH->toc, te);
14461444
}
14471445

14481446
if (fclose(fh) != 0)
@@ -1804,7 +1802,7 @@ _moveAfter(ArchiveHandle *AH, TocEntry *pos, TocEntry *te)
18041802
#endif
18051803

18061804
static void
1807-
_moveBefore(ArchiveHandle *AH, TocEntry *pos, TocEntry *te)
1805+
_moveBefore(TocEntry *pos, TocEntry *te)
18081806
{
18091807
/* Unlink te from list */
18101808
te->prev->next = te->next;
@@ -3465,7 +3463,7 @@ _selectTableAccessMethod(ArchiveHandle *AH, const char *tableam)
34653463
* This is used for ALTER ... OWNER TO.
34663464
*/
34673465
static void
3468-
_getObjectDescription(PQExpBuffer buf, TocEntry *te, ArchiveHandle *AH)
3466+
_getObjectDescription(PQExpBuffer buf, TocEntry *te)
34693467
{
34703468
const char *type = te->desc;
34713469

@@ -3674,7 +3672,7 @@ _printTocEntry(ArchiveHandle *AH, TocEntry *te, bool isData)
36743672
PQExpBuffer temp = createPQExpBuffer();
36753673

36763674
appendPQExpBufferStr(temp, "ALTER ");
3677-
_getObjectDescription(temp, te, AH);
3675+
_getObjectDescription(temp, te);
36783676
appendPQExpBuffer(temp, " OWNER TO %s;", fmtId(te->owner));
36793677
ahprintf(AH, "%s\n\n", temp->data);
36803678
destroyPQExpBuffer(temp);
@@ -4078,7 +4076,7 @@ restore_toc_entries_parallel(ArchiveHandle *AH, ParallelState *pstate,
40784076
for (;;)
40794077
{
40804078
/* Look for an item ready to be dispatched to a worker */
4081-
next_work_item = pop_next_work_item(AH, &ready_list, pstate);
4079+
next_work_item = pop_next_work_item(&ready_list, pstate);
40824080
if (next_work_item != NULL)
40834081
{
40844082
/* If not to be restored, don't waste time launching a worker */
@@ -4384,7 +4382,7 @@ move_to_ready_list(TocEntry *pending_list,
43844382
* no remaining dependencies, but we have to check for lock conflicts.
43854383
*/
43864384
static TocEntry *
4387-
pop_next_work_item(ArchiveHandle *AH, ParallelReadyList *ready_list,
4385+
pop_next_work_item(ParallelReadyList *ready_list,
43884386
ParallelState *pstate)
43894387
{
43904388
/*

‎src/bin/pg_dump/pg_backup_tar.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ static void tarClose(ArchiveHandle *AH, TAR_MEMBER *TH);
107107
#ifdef __NOT_USED__
108108
static char *tarGets(char *buf, size_t len, TAR_MEMBER *th);
109109
#endif
110-
static int tarPrintf(ArchiveHandle *AH, TAR_MEMBER *th, const char *fmt,...) pg_attribute_printf(3, 4);
110+
static int tarPrintf(TAR_MEMBER *th, const char *fmt,...) pg_attribute_printf(2, 3);
111111

112112
static void _tarAddFile(ArchiveHandle *AH, TAR_MEMBER *th);
113113
static TAR_MEMBER *_tarPositionTo(ArchiveHandle *AH, const char *filename);
@@ -851,7 +851,7 @@ _CloseArchive(ArchiveHandle *AH)
851851
*/
852852
th = tarOpen(AH, "restore.sql", 'w');
853853

854-
tarPrintf(AH, th, "--\n"
854+
tarPrintf(th, "--\n"
855855
"-- NOTE:\n"
856856
"--\n"
857857
"-- File paths need to be edited. Search for $$PATH$$ and\n"
@@ -964,7 +964,7 @@ _StartBlob(ArchiveHandle *AH, TocEntry *te, Oid oid)
964964

965965
sprintf(fname, "blob_%u.dat%s", oid, sfx);
966966

967-
tarPrintf(AH, ctx->blobToc, "%u %s\n", oid, fname);
967+
tarPrintf(ctx->blobToc, "%u %s\n", oid, fname);
968968

969969
tctx->TH = tarOpen(AH, fname, 'w');
970970
}
@@ -1008,7 +1008,7 @@ _EndBlobs(ArchiveHandle *AH, TocEntry *te)
10081008
*/
10091009

10101010
static int
1011-
tarPrintf(ArchiveHandle *AH, TAR_MEMBER *th, const char *fmt,...)
1011+
tarPrintf(TAR_MEMBER *th, const char *fmt,...)
10121012
{
10131013
int save_errno = errno;
10141014
char *p;

‎src/bin/pg_dump/pg_dump.c

Lines changed: 28 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ static void expand_table_name_patterns(Archive *fout,
157157
SimpleStringList *patterns,
158158
SimpleOidList *oids,
159159
bool strict_names);
160-
static NamespaceInfo *findNamespace(Archive *fout, Oid nsoid);
160+
static NamespaceInfo *findNamespace(Oid nsoid);
161161
static void dumpTableData(Archive *fout, TableDataInfo *tdinfo);
162162
static void refreshMatViewData(Archive *fout, TableDataInfo *tdinfo);
163163
static void guessConstraintInheritance(TableInfo *tblinfo, int numTables);
@@ -250,9 +250,8 @@ static char *format_function_arguments_old(Archive *fout,
250250
char **argnames);
251251
static char *format_function_signature(Archive *fout,
252252
FuncInfo *finfo, bool honor_quotes);
253-
static char *convertRegProcReference(Archive *fout,
254-
const char *proc);
255-
static char *getFormattedOperatorName(Archive *fout, const char *oproid);
253+
static char *convertRegProcReference(const char *proc);
254+
static char *getFormattedOperatorName(const char *oproid);
256255
static char *convertTSFunction(Archive *fout, Oid funcOid);
257256
static Oid findLastBuiltinOid_V71(Archive *fout);
258257
static char *getFormattedTypeName(Archive *fout, Oid oid, OidOptions opts);
@@ -2974,7 +2973,7 @@ dumpDatabase(Archive *fout)
29742973

29752974
seclabelQry = createPQExpBuffer();
29762975

2977-
buildShSecLabelQuery(conn, "pg_database", dbCatId.oid, seclabelQry);
2976+
buildShSecLabelQuery("pg_database", dbCatId.oid, seclabelQry);
29782977
shres = ExecuteSqlQuery(fout, seclabelQry->data, PGRES_TUPLES_OK);
29792978
resetPQExpBuffer(seclabelQry);
29802979
emitShSecLabels(conn, shres, seclabelQry, "DATABASE", datname);
@@ -4811,7 +4810,7 @@ getNamespaces(Archive *fout, int *numNamespaces)
48114810
* given a namespace OID, look up the info read by getNamespaces
48124811
*/
48134812
static NamespaceInfo *
4814-
findNamespace(Archive *fout, Oid nsoid)
4813+
findNamespace(Oid nsoid)
48154814
{
48164815
NamespaceInfo *nsinfo;
48174816

@@ -5069,8 +5068,7 @@ getTypes(Archive *fout, int *numTypes)
50695068
AssignDumpId(&tyinfo[i].dobj);
50705069
tyinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_typname));
50715070
tyinfo[i].dobj.namespace =
5072-
findNamespace(fout,
5073-
atooid(PQgetvalue(res, i, i_typnamespace)));
5071+
findNamespace(atooid(PQgetvalue(res, i, i_typnamespace)));
50745072
tyinfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
50755073
tyinfo[i].typacl = pg_strdup(PQgetvalue(res, i, i_typacl));
50765074
tyinfo[i].rtypacl = pg_strdup(PQgetvalue(res, i, i_rtypacl));
@@ -5214,8 +5212,7 @@ getOperators(Archive *fout, int *numOprs)
52145212
AssignDumpId(&oprinfo[i].dobj);
52155213
oprinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_oprname));
52165214
oprinfo[i].dobj.namespace =
5217-
findNamespace(fout,
5218-
atooid(PQgetvalue(res, i, i_oprnamespace)));
5215+
findNamespace(atooid(PQgetvalue(res, i, i_oprnamespace)));
52195216
oprinfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
52205217
oprinfo[i].oprkind = (PQgetvalue(res, i, i_oprkind))[0];
52215218
oprinfo[i].oprcode = atooid(PQgetvalue(res, i, i_oprcode));
@@ -5300,8 +5297,7 @@ getCollations(Archive *fout, int *numCollations)
53005297
AssignDumpId(&collinfo[i].dobj);
53015298
collinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_collname));
53025299
collinfo[i].dobj.namespace =
5303-
findNamespace(fout,
5304-
atooid(PQgetvalue(res, i, i_collnamespace)));
5300+
findNamespace(atooid(PQgetvalue(res, i, i_collnamespace)));
53055301
collinfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
53065302

53075303
/* Decide whether we want to dump it */
@@ -5373,8 +5369,7 @@ getConversions(Archive *fout, int *numConversions)
53735369
AssignDumpId(&convinfo[i].dobj);
53745370
convinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_conname));
53755371
convinfo[i].dobj.namespace =
5376-
findNamespace(fout,
5377-
atooid(PQgetvalue(res, i, i_connamespace)));
5372+
findNamespace(atooid(PQgetvalue(res, i, i_connamespace)));
53785373
convinfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
53795374

53805375
/* Decide whether we want to dump it */
@@ -5518,8 +5513,7 @@ getOpclasses(Archive *fout, int *numOpclasses)
55185513
AssignDumpId(&opcinfo[i].dobj);
55195514
opcinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_opcname));
55205515
opcinfo[i].dobj.namespace =
5521-
findNamespace(fout,
5522-
atooid(PQgetvalue(res, i, i_opcnamespace)));
5516+
findNamespace(atooid(PQgetvalue(res, i, i_opcnamespace)));
55235517
opcinfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
55245518

55255519
/* Decide whether we want to dump it */
@@ -5602,8 +5596,7 @@ getOpfamilies(Archive *fout, int *numOpfamilies)
56025596
AssignDumpId(&opfinfo[i].dobj);
56035597
opfinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_opfname));
56045598
opfinfo[i].dobj.namespace =
5605-
findNamespace(fout,
5606-
atooid(PQgetvalue(res, i, i_opfnamespace)));
5599+
findNamespace(atooid(PQgetvalue(res, i, i_opfnamespace)));
56075600
opfinfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
56085601

56095602
/* Decide whether we want to dump it */
@@ -5778,8 +5771,7 @@ getAggregates(Archive *fout, int *numAggs)
57785771
AssignDumpId(&agginfo[i].aggfn.dobj);
57795772
agginfo[i].aggfn.dobj.name = pg_strdup(PQgetvalue(res, i, i_aggname));
57805773
agginfo[i].aggfn.dobj.namespace =
5781-
findNamespace(fout,
5782-
atooid(PQgetvalue(res, i, i_aggnamespace)));
5774+
findNamespace(atooid(PQgetvalue(res, i, i_aggnamespace)));
57835775
agginfo[i].aggfn.rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
57845776
if (strlen(agginfo[i].aggfn.rolname) == 0)
57855777
pg_log_warning("owner of aggregate function \"%s\" appears to be invalid",
@@ -6013,8 +6005,7 @@ getFuncs(Archive *fout, int *numFuncs)
60136005
AssignDumpId(&finfo[i].dobj);
60146006
finfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_proname));
60156007
finfo[i].dobj.namespace =
6016-
findNamespace(fout,
6017-
atooid(PQgetvalue(res, i, i_pronamespace)));
6008+
findNamespace(atooid(PQgetvalue(res, i, i_pronamespace)));
60186009
finfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
60196010
finfo[i].lang = atooid(PQgetvalue(res, i, i_prolang));
60206011
finfo[i].prorettype = atooid(PQgetvalue(res, i, i_prorettype));
@@ -6751,8 +6742,7 @@ getTables(Archive *fout, int *numTables)
67516742
AssignDumpId(&tblinfo[i].dobj);
67526743
tblinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_relname));
67536744
tblinfo[i].dobj.namespace =
6754-
findNamespace(fout,
6755-
atooid(PQgetvalue(res, i, i_relnamespace)));
6745+
findNamespace(atooid(PQgetvalue(res, i, i_relnamespace)));
67566746
tblinfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
67576747
tblinfo[i].relacl = pg_strdup(PQgetvalue(res, i, i_relacl));
67586748
tblinfo[i].rrelacl = pg_strdup(PQgetvalue(res, i, i_rrelacl));
@@ -7413,8 +7403,7 @@ getExtendedStatistics(Archive *fout)
74137403
AssignDumpId(&statsextinfo[i].dobj);
74147404
statsextinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_stxname));
74157405
statsextinfo[i].dobj.namespace =
7416-
findNamespace(fout,
7417-
atooid(PQgetvalue(res, i, i_stxnamespace)));
7406+
findNamespace(atooid(PQgetvalue(res, i, i_stxnamespace)));
74187407
statsextinfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
74197408
statsextinfo[i].stattarget = atoi(PQgetvalue(res, i, i_stattarget));
74207409

@@ -8952,8 +8941,7 @@ getTSParsers(Archive *fout, int *numTSParsers)
89528941
AssignDumpId(&prsinfo[i].dobj);
89538942
prsinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_prsname));
89548943
prsinfo[i].dobj.namespace =
8955-
findNamespace(fout,
8956-
atooid(PQgetvalue(res, i, i_prsnamespace)));
8944+
findNamespace(atooid(PQgetvalue(res, i, i_prsnamespace)));
89578945
prsinfo[i].prsstart = atooid(PQgetvalue(res, i, i_prsstart));
89588946
prsinfo[i].prstoken = atooid(PQgetvalue(res, i, i_prstoken));
89598947
prsinfo[i].prsend = atooid(PQgetvalue(res, i, i_prsend));
@@ -9035,8 +9023,7 @@ getTSDictionaries(Archive *fout, int *numTSDicts)
90359023
AssignDumpId(&dictinfo[i].dobj);
90369024
dictinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_dictname));
90379025
dictinfo[i].dobj.namespace =
9038-
findNamespace(fout,
9039-
atooid(PQgetvalue(res, i, i_dictnamespace)));
9026+
findNamespace(atooid(PQgetvalue(res, i, i_dictnamespace)));
90409027
dictinfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
90419028
dictinfo[i].dicttemplate = atooid(PQgetvalue(res, i, i_dicttemplate));
90429029
if (PQgetisnull(res, i, i_dictinitoption))
@@ -9115,8 +9102,7 @@ getTSTemplates(Archive *fout, int *numTSTemplates)
91159102
AssignDumpId(&tmplinfo[i].dobj);
91169103
tmplinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_tmplname));
91179104
tmplinfo[i].dobj.namespace =
9118-
findNamespace(fout,
9119-
atooid(PQgetvalue(res, i, i_tmplnamespace)));
9105+
findNamespace(atooid(PQgetvalue(res, i, i_tmplnamespace)));
91209106
tmplinfo[i].tmplinit = atooid(PQgetvalue(res, i, i_tmplinit));
91219107
tmplinfo[i].tmpllexize = atooid(PQgetvalue(res, i, i_tmpllexize));
91229108

@@ -9192,8 +9178,7 @@ getTSConfigurations(Archive *fout, int *numTSConfigs)
91929178
AssignDumpId(&cfginfo[i].dobj);
91939179
cfginfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_cfgname));
91949180
cfginfo[i].dobj.namespace =
9195-
findNamespace(fout,
9196-
atooid(PQgetvalue(res, i, i_cfgnamespace)));
9181+
findNamespace(atooid(PQgetvalue(res, i, i_cfgnamespace)));
91979182
cfginfo[i].rolname = pg_strdup(PQgetvalue(res, i, i_rolname));
91989183
cfginfo[i].cfgparser = atooid(PQgetvalue(res, i, i_cfgparser));
91999184

@@ -9640,7 +9625,7 @@ getDefaultACLs(Archive *fout, int *numDefaultACLs)
96409625
daclinfo[i].dobj.name = pg_strdup(PQgetvalue(res, i, i_defaclobjtype));
96419626

96429627
if (nspid != InvalidOid)
9643-
daclinfo[i].dobj.namespace = findNamespace(fout, nspid);
9628+
daclinfo[i].dobj.namespace = findNamespace(nspid);
96449629
else
96459630
daclinfo[i].dobj.namespace = NULL;
96469631

@@ -12655,7 +12640,7 @@ dumpOpr(Archive *fout, OprInfo *oprinfo)
1265512640
pg_log_warning("postfix operators are not supported anymore (operator \"%s\")",
1265612641
oprcode);
1265712642

12658-
oprregproc = convertRegProcReference(fout, oprcode);
12643+
oprregproc = convertRegProcReference(oprcode);
1265912644
if (oprregproc)
1266012645
{
1266112646
appendPQExpBuffer(details, " FUNCTION = %s", oprregproc);
@@ -12688,14 +12673,14 @@ dumpOpr(Archive *fout, OprInfo *oprinfo)
1268812673
else
1268912674
appendPQExpBufferStr(oprid, ", NONE)");
1269012675

12691-
oprref = getFormattedOperatorName(fout, oprcom);
12676+
oprref = getFormattedOperatorName(oprcom);
1269212677
if (oprref)
1269312678
{
1269412679
appendPQExpBuffer(details, ",\n COMMUTATOR = %s", oprref);
1269512680
free(oprref);
1269612681
}
1269712682

12698-
oprref = getFormattedOperatorName(fout, oprnegate);
12683+
oprref = getFormattedOperatorName(oprnegate);
1269912684
if (oprref)
1270012685
{
1270112686
appendPQExpBuffer(details, ",\n NEGATOR = %s", oprref);
@@ -12708,14 +12693,14 @@ dumpOpr(Archive *fout, OprInfo *oprinfo)
1270812693
if (strcmp(oprcanhash, "t") == 0)
1270912694
appendPQExpBufferStr(details, ",\n HASHES");
1271012695

12711-
oprregproc = convertRegProcReference(fout, oprrest);
12696+
oprregproc = convertRegProcReference(oprrest);
1271212697
if (oprregproc)
1271312698
{
1271412699
appendPQExpBuffer(details, ",\n RESTRICT = %s", oprregproc);
1271512700
free(oprregproc);
1271612701
}
1271712702

12718-
oprregproc = convertRegProcReference(fout, oprjoin);
12703+
oprregproc = convertRegProcReference(oprjoin);
1271912704
if (oprregproc)
1272012705
{
1272112706
appendPQExpBuffer(details, ",\n JOIN = %s", oprregproc);
@@ -12770,7 +12755,7 @@ dumpOpr(Archive *fout, OprInfo *oprinfo)
1277012755
* part.
1277112756
*/
1277212757
static char *
12773-
convertRegProcReference(Archive *fout, const char *proc)
12758+
convertRegProcReference(const char *proc)
1277412759
{
1277512760
char *name;
1277612761
char *paren;
@@ -12811,7 +12796,7 @@ convertRegProcReference(Archive *fout, const char *proc)
1281112796
* are in different schemas.
1281212797
*/
1281312798
static char *
12814-
getFormattedOperatorName(Archive *fout, const char *oproid)
12799+
getFormattedOperatorName(const char *oproid)
1281512800
{
1281612801
OprInfo *oprInfo;
1281712802

@@ -14121,7 +14106,7 @@ dumpAgg(Archive *fout, AggInfo *agginfo)
1412114106
}
1412214107
}
1412314108

14124-
aggsortconvop = getFormattedOperatorName(fout, aggsortop);
14109+
aggsortconvop = getFormattedOperatorName(aggsortop);
1412514110
if (aggsortconvop)
1412614111
{
1412714112
appendPQExpBuffer(details, ",\n SORTOP = %s",

0 commit comments

Comments
 (0)