Improve pg_basebackup long file name test Windows robustness

adunstan · adunstan · commit 83ed4de20fdb · 2023-07-03T10:07:24.000-04:00
Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.

Error displayed by buildfarm animal fairywren.o

Backpatch to all live branches
diff --git a/src/bin/pg_basebackup/t/010_pg_basebackup.pl b/src/bin/pg_basebackup/t/010_pg_basebackup.pl
@@ -203,16 +203,20 @@
 	'-T with invalid format fails');
 
 # Tar format doesn't support filenames longer than 100 bytes.
+# Create the test file via a short name directory so it doesn't blow the
+# Windows path limit.
+my $lftmp = PostgreSQL::Test::Utils::tempdir_short;
+dir_symlink "$pgdata", "$lftmp/pgdata";
 my $superlongname = "superlongname_" . ("x" x 100);
-my $superlongpath = "$pgdata/$superlongname";
+my $superlongpath = "$lftmp/pgdata/$superlongname";
 
 open my $file, '>', "$superlongpath"
   or die "unable to create file $superlongpath";
 close $file;
 $node->command_fails(
 	[ 'pg_basebackup', '-D', "$tempdir/tarbackup_l1", '-Ft' ],
 	'pg_basebackup tar with long name fails');
-unlink "$pgdata/$superlongname";
+unlink "$superlongpath";
 
 # The following tests are for symlinks.
 
