Remove Assert that matview is not in system schema from REFRESH.

kgrittn · kgrittn · commit 85052376a8cc · 2013-08-14T12:43:01.000-05:00
We don't want to prevent an extension which creates a matview from
being installed in pg_catalog.

Issue was raised by Hitoshi Harada.
Backpatched to 9.3.
diff --git a/src/backend/commands/matview.c b/src/backend/commands/matview.c
@@ -144,11 +144,7 @@ ExecRefreshMatView(RefreshMatViewStmt *stmt, const char *queryString,
 				 errmsg("\"%s\" is not a materialized view",
 						RelationGetRelationName(matviewRel))));
 
-	/*
-	 * We're not using materialized views in the system catalogs.
-	 */
-	Assert(!IsSystemRelation(matviewRel));
-
+	/* We don't allow an oid column for a materialized view. */
 	Assert(!matviewRel->rd_rel->relhasoids);
 
 	/*
