Remove non-existing variable reference in MSVC's Solution.pm

michaelpq · michaelpq · commit 88274a7a314e · 2021-06-26T13:52:54.000+09:00
The version string is grabbed from PACKAGE_VERSION in pg_config.h in the MSVC build since 8f4fb4c, but an error message referenced a variable that existed before that. This had no consequences except if one messes up enough with the version number of the build. Author: Anton Voloshin Discussion: https://postgr.es/m/af79ee1b-9962-b299-98e1-f90a289e19e6@postgrespro.ru Backpatch-through: 13
diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
@@ -171,7 +171,7 @@ sub GenerateFiles
 
 			if ($package_version !~ /^(\d+)(?:\.(\d+))?/)
 			{
-				confess "Bad format of version: $self->{strver}\n";
+				confess "Bad format of version: $package_version\n";
 			}
 			$majorver = sprintf("%d", $1);
 			$minorver = sprintf("%d", $2 ? $2 : 0);

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ sub GenerateFiles`
`171`	`171`
`172`	`172`	`if ($package_version !~ /^(\d+)(?:\.(\d+))?/)`
`173`	`173`	`{`
`174`		`- confess "Bad format of version: $self->{strver}\n";`
	`174`	`+ confess "Bad format of version: $package_version\n";`
`175`	`175`	`}`
`176`	`176`	`$majorver = sprintf("%d", $1);`
`177`	`177`	`$minorver = sprintf("%d", $2 ? $2 : 0);`