Fix portability issue in tests from commit ce773f2.

tglsfdc · tglsfdc · commit 9089f1543ef5 · 2021-09-03T10:01:02.000-04:00
Modern POSIX seems to require strtod() to accept "-NaN", but there's
nothing about NaN in SUSv2, and some of our oldest buildfarm members
don't like it.  Let's try writing it as -'NaN' instead; that seems
to produce the same result, at least on Intel hardware.

Per buildfarm.
diff --git a/src/test/regress/expected/hash_func.out b/src/test/regress/expected/hash_func.out
@@ -307,7 +307,7 @@ SELECT hashfloat4('0'::float4) = hashfloat4('-0'::float4) AS t;
  t
 (1 row)
 
-SELECT hashfloat4('NaN'::float4) = hashfloat4('-NaN'::float4) AS t;
+SELECT hashfloat4('NaN'::float4) = hashfloat4(-'NaN'::float4) AS t;
  t 
 ---
  t
@@ -319,7 +319,7 @@ SELECT hashfloat8('0'::float8) = hashfloat8('-0'::float8) AS t;
  t
 (1 row)
 
-SELECT hashfloat8('NaN'::float8) = hashfloat8('-NaN'::float8) AS t;
+SELECT hashfloat8('NaN'::float8) = hashfloat8(-'NaN'::float8) AS t;
  t 
 ---
  t
diff --git a/src/test/regress/sql/hash_func.sql b/src/test/regress/sql/hash_func.sql
@@ -225,7 +225,7 @@ WHERE  hash_range(v)::bit(32) != hash_range_extended(v, 0)::bit(32)
 -- Check special cases for specific data types
 --
 SELECT hashfloat4('0'::float4) = hashfloat4('-0'::float4) AS t;
-SELECT hashfloat4('NaN'::float4) = hashfloat4('-NaN'::float4) AS t;
+SELECT hashfloat4('NaN'::float4) = hashfloat4(-'NaN'::float4) AS t;
 SELECT hashfloat8('0'::float8) = hashfloat8('-0'::float8) AS t;
-SELECT hashfloat8('NaN'::float8) = hashfloat8('-NaN'::float8) AS t;
+SELECT hashfloat8('NaN'::float8) = hashfloat8(-'NaN'::float8) AS t;
 SELECT hashfloat4('NaN'::float4) = hashfloat8('NaN'::float8) AS t;

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ SELECT hashfloat4('0'::float4) = hashfloat4('-0'::float4) AS t;`
`307`	`307`	`t`
`308`	`308`	`(1 row)`
`309`	`309`
`310`		`-SELECT hashfloat4('NaN'::float4) = hashfloat4('-NaN'::float4) AS t;`
	`310`	`+SELECT hashfloat4('NaN'::float4) = hashfloat4(-'NaN'::float4) AS t;`
`311`	`311`	`t`
`312`	`312`	`---`
`313`	`313`	`t`
`@@ -319,7 +319,7 @@ SELECT hashfloat8('0'::float8) = hashfloat8('-0'::float8) AS t;`
`319`	`319`	`t`
`320`	`320`	`(1 row)`
`321`	`321`
`322`		`-SELECT hashfloat8('NaN'::float8) = hashfloat8('-NaN'::float8) AS t;`
	`322`	`+SELECT hashfloat8('NaN'::float8) = hashfloat8(-'NaN'::float8) AS t;`
`323`	`323`	`t`
`324`	`324`	`---`
`325`	`325`	`t`