Clean up sloppy coding of _outAExpr().

tglsfdc · tglsfdc · commit 92286bd57602 · 2000-05-25T22:43:12.000Z
diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1996-2000, PostgreSQL, Inc
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- *	$Header: /cvsroot/pgsql/src/backend/nodes/outfuncs.c,v 1.115 2000/04/26 23:39:10 tgl Exp $
+ *	$Header: /cvsroot/pgsql/src/backend/nodes/outfuncs.c,v 1.116 2000/05/25 22:43:12 tgl Exp $
  *
  * NOTES
  *	  Every (plan) node in POSTGRES has an associated "out" routine which
@@ -1255,7 +1255,7 @@ _outStream(StringInfo str, Stream *node)
 static void
 _outAExpr(StringInfo str, A_Expr *node)
 {
-	appendStringInfo(str, "EXPR ");
+	appendStringInfo(str, " AEXPR ");
 	switch (node->oper)
 	{
 		case AND:
@@ -1273,12 +1273,16 @@ _outAExpr(StringInfo str, A_Expr *node)
 		case NOTNULL:
 			appendStringInfo(str, "NOTNULL ");
 			break;
-		default:
+		case OP:
 			_outToken(str, node->opname);
 			appendStringInfo(str, " ");
 			break;
+		default:
+			appendStringInfo(str, "?? ");
+			break;
 	}
 	_outNode(str, node->lexpr);
+	appendStringInfo(str, " ");
 	_outNode(str, node->rexpr);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* Portions Copyright (c) 1996-2000, PostgreSQL, Inc`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`		`- * $Header: /cvsroot/pgsql/src/backend/nodes/outfuncs.c,v 1.115 2000/04/26 23:39:10 tgl Exp $`
	`9`	`+ * $Header: /cvsroot/pgsql/src/backend/nodes/outfuncs.c,v 1.116 2000/05/25 22:43:12 tgl Exp $`
`10`	`10`	`*`
`11`	`11`	`* NOTES`
`12`	`12`	`* Every (plan) node in POSTGRES has an associated "out" routine which`
`@@ -1255,7 +1255,7 @@ _outStream(StringInfo str, Stream *node)`
`1255`	`1255`	`static void`
`1256`	`1256`	`_outAExpr(StringInfo str, A_Expr *node)`
`1257`	`1257`	`{`
`1258`		`- appendStringInfo(str, "EXPR ");`
	`1258`	`+ appendStringInfo(str, " AEXPR ");`
`1259`	`1259`	`switch (node->oper)`
`1260`	`1260`	`{`
`1261`	`1261`	`case AND:`
`@@ -1273,12 +1273,16 @@ _outAExpr(StringInfo str, A_Expr *node)`
`1273`	`1273`	`case NOTNULL:`
`1274`	`1274`	`appendStringInfo(str, "NOTNULL ");`
`1275`	`1275`	`break;`
`1276`		`- default:`
	`1276`	`+ case OP:`
`1277`	`1277`	`_outToken(str, node->opname);`
`1278`	`1278`	`appendStringInfo(str, " ");`
`1279`	`1279`	`break;`
	`1280`	`+ default:`
	`1281`	`+ appendStringInfo(str, "?? ");`
	`1282`	`+ break;`
`1280`	`1283`	`}`
`1281`	`1284`	`_outNode(str, node->lexpr);`
	`1285`	`+ appendStringInfo(str, " ");`
`1282`	`1286`	`_outNode(str, node->rexpr);`
`1283`	`1287`	`}`
`1284`	`1288`