Revert "Add temporary debug logging, in 9.4 branch only."

tglsfdc · tglsfdc · commit 92b503c48d9d · 2018-04-18T11:57:37.000-04:00
This reverts commit e55380f. It's served its purpose.
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c
@@ -758,8 +758,6 @@ DefineIndex(Oid relationId,
 	 */
 	validate_index(relationId, indexRelationId, snapshot);
 
-	PrintSnapMgrStatus("concurrent index build, before snapshot release");
-
 	/*
 	 * Drop the reference snapshot.  We must do this before waiting out other
 	 * snapshot holders, else we will deadlock against other processes also
@@ -772,13 +770,9 @@ DefineIndex(Oid relationId,
 	limitXmin = snapshot->xmin;
 
 	PopActiveSnapshot();
-	PrintSnapMgrStatus("concurrent index build, after PopActiveSnapshot");
 	UnregisterSnapshot(snapshot);
-	PrintSnapMgrStatus("concurrent index build, after UnregisterSnapshot");
 	InvalidateCatalogSnapshot();
 
-	PrintSnapMgrStatus("concurrent index build, after InvalidateCatalogSnapshot");
-
 	/*
 	 * The index is now valid in the sense that it contains all currently
 	 * interesting tuples.  But since it might not contain tuples deleted just
diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c
@@ -1401,17 +1401,3 @@ HistoricSnapshotGetTupleCids(void)
 	Assert(HistoricSnapshotActive());
 	return tuplecid_data;
 }
-
-void
-PrintSnapMgrStatus(const char *context)
-{
-	int			asdepth = 0;
-	ActiveSnapshotElt *active;
-
-	for (active = ActiveSnapshot; active != NULL; active = active->as_next)
-		asdepth++;
-
-	elog(LOG, "%s: %d reg snaps, %d active snaps, cat snap %p, xmin %u",
-		 context, RegisteredSnapshots, asdepth,
-		 CatalogSnapshot, MyPgXact->xmin);
-}
diff --git a/src/include/utils/snapmgr.h b/src/include/utils/snapmgr.h
@@ -65,6 +65,4 @@ extern void SetupHistoricSnapshot(Snapshot snapshot_now, struct HTAB *tuplecids)
 extern void TeardownHistoricSnapshot(bool is_error);
 extern bool HistoricSnapshotActive(void);
 
-extern void PrintSnapMgrStatus(const char *context);
-
 #endif   /* SNAPMGR_H */
