Allow "dbname" from connection string to be overridden in PQconnectDBParams

hlinnaka · hlinnaka · commit 9b468bcec15f · 2014-11-25T17:39:04.000+02:00
If the "dbname" attribute in PQconnectDBParams contained a connection string
or URI (and expand_dbname = TRUE), the database name from the connection
string could not be overridden by a subsequent "dbname" keyword in the
array. That was not intentional; all other options can be overridden.
Furthermore, any subsequent "dbname" caused the connection string from the
first dbname value to be processed again, overriding any values for the same
options that were given between the connection string and the second dbname
option.

In the passing, clarify in the docs that only the first dbname option in the
array is parsed as a connection string.

Alex Shulgin. Backpatch to all supported versions.
diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
@@ -124,7 +124,10 @@ PGconn *PQconnectdbParams(const char * const *keywords,
       <para>
        When <literal>expand_dbname</literal> is non-zero, the
        <parameter>dbname</parameter> key word value is allowed to be recognized
-       as a connection string. More details on the possible formats appear in
+       as a connection string. Only the first occurrence of
+       <parameter>dbname</parameter> is expanded this way, any subsequent
+       <parameter>dbname</parameter> value is processed as plain database name. More
+       details on the possible connection string formats appear in
        <xref linkend="libpq-connstring">.
       </para>
 
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
@@ -4400,10 +4400,11 @@ conninfo_parse(const char *conninfo, PQExpBuffer errorMessage,
  * Defaults are supplied (from a service file, environment variables, etc)
  * for unspecified options, but only if use_defaults is TRUE.
  *
- * If expand_dbname is non-zero, and the value passed for keyword "dbname" is a
- * connection string (as indicated by recognized_connection_string) then parse
- * and process it, overriding any previously processed conflicting
- * keywords. Subsequent keywords will take precedence, however.
+ * If expand_dbname is non-zero, and the value passed for the first occurrence
+ * of "dbname" keyword is a connection string (as indicated by
+ * recognized_connection_string) then parse and process it, overriding any
+ * previously processed conflicting keywords. Subsequent keywords will take
+ * precedence, however.
  */
 static PQconninfoOption *
 conninfo_array_parse(const char *const * keywords, const char *const * values,
@@ -4479,7 +4480,7 @@ conninfo_array_parse(const char *const * keywords, const char *const * values,
 			}
 
 			/*
-			 * If we are on the dbname parameter, and we have a parsed
+			 * If we are on the first dbname parameter, and we have a parsed
 			 * connection string, copy those parameters across, overriding any
 			 * existing previous settings.
 			 */
@@ -4513,6 +4514,12 @@ conninfo_array_parse(const char *const * keywords, const char *const * values,
 						}
 					}
 				}
+				/*
+				 * Forget the parsed connection string, so that any subsequent
+				 * dbname parameters will not be expanded.
+				 */
+				PQconninfoFree(dbname_options);
+				dbname_options = NULL;
 			}
 			else
 			{

Original file line number	Diff line number	Diff line change
`@@ -4400,10 +4400,11 @@ conninfo_parse(const char *conninfo, PQExpBuffer errorMessage,`
`4400`	`4400`	`* Defaults are supplied (from a service file, environment variables, etc)`
`4401`	`4401`	`* for unspecified options, but only if use_defaults is TRUE.`
`4402`	`4402`	`*`
`4403`		`- * If expand_dbname is non-zero, and the value passed for keyword "dbname" is a`
`4404`		`- * connection string (as indicated by recognized_connection_string) then parse`
`4405`		`- * and process it, overriding any previously processed conflicting`
`4406`		`- * keywords. Subsequent keywords will take precedence, however.`
	`4403`	`+ * If expand_dbname is non-zero, and the value passed for the first occurrence`
	`4404`	`+ * of "dbname" keyword is a connection string (as indicated by`
	`4405`	`+ * recognized_connection_string) then parse and process it, overriding any`
	`4406`	`+ * previously processed conflicting keywords. Subsequent keywords will take`
	`4407`	`+ * precedence, however.`
`4407`	`4408`	`*/`
`4408`	`4409`	`static PQconninfoOption *`
`4409`	`4410`	`conninfo_array_parse(const char const keywords, const char const values,`
`@@ -4479,7 +4480,7 @@ conninfo_array_parse(const char const keywords, const char const values,`
`4479`	`4480`	`}`
`4480`	`4481`
`4481`	`4482`	`/*`
`4482`		`- * If we are on the dbname parameter, and we have a parsed`
	`4483`	`+ * If we are on the first dbname parameter, and we have a parsed`
`4483`	`4484`	`* connection string, copy those parameters across, overriding any`
`4484`	`4485`	`* existing previous settings.`
`4485`	`4486`	`*/`
`@@ -4513,6 +4514,12 @@ conninfo_array_parse(const char const keywords, const char const values,`
`4513`	`4514`	`}`
`4514`	`4515`	`}`
`4515`	`4516`	`}`
	`4517`	`+ /*`
	`4518`	`+ * Forget the parsed connection string, so that any subsequent`
	`4519`	`+ * dbname parameters will not be expanded.`
	`4520`	`+ */`
	`4521`	`+ PQconninfoFree(dbname_options);`
	`4522`	`+ dbname_options = NULL;`
`4516`	`4523`	`}`
`4517`	`4524`	`else`
`4518`	`4525`	`{`