Fixes:

scrappy · scrappy · commit 9da9c0915a50 · 1996-08-13T01:32:26.000Z
Here's a small patch that my run-time checker whines about incessantly. The justification for the patch is along the lines of passing a NULL is allowed if you have an arguement that is a *POINTER* to something, but if the arguement is an array reference, it's not really a "pointer", so it can't be NULL. If you question this, I refer you to <URL:http://www.va.pubnix.com/staff/djm/lore/arrays-are-not-pointers> Anyways, here's the patch: -Kurt Submitted by: "Kurt J. Lidl" <lidl@va.pubnix.com>
diff --git a/src/backend/access/common/heaptuple.c b/src/backend/access/common/heaptuple.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/access/common/heaptuple.c,v 1.1.1.1 1996/07/09 06:21:09 scrappy Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/access/common/heaptuple.c,v 1.2 1996/08/13 01:32:26 scrappy Exp $
  *
  * NOTES
  *    The old interface functions have been converted to macros
@@ -114,7 +114,7 @@ DataFill(char *data,
 	 Datum value[],
 	 char nulls[],
 	 char *infomask,
-	 bits8 bit[])
+	 bits8 *bit)
 {
     bits8	*bitP;
     int		bitmask;
diff --git a/src/backend/access/heapam.h b/src/backend/access/heapam.h
@@ -6,7 +6,7 @@
  *
  * Copyright (c) 1994, Regents of the University of California
  *
- * $Id: heapam.h,v 1.1.1.1 1996/07/09 06:21:08 scrappy Exp $
+ * $Id: heapam.h,v 1.2 1996/08/13 01:32:17 scrappy Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -120,7 +120,7 @@ extern void heap_restrpos(HeapScanDesc sdesc);
 extern Size ComputeDataSize(TupleDesc tupleDesc, Datum value[], char nulls[]);
 extern void DataFill(char *data, TupleDesc tupleDesc,
 		     Datum value[], char nulls[], char *infomask,
-		     bits8 bit[]);
+		     bits8 *bit);
 extern int heap_attisnull(HeapTuple tup, int attnum);
 extern int heap_sysattrlen(AttrNumber attno);
 extern bool heap_sysattrbyval(AttrNumber attno);

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/access/common/heaptuple.c,v 1.1.1.1 1996/07/09 06:21:09 scrappy Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/access/common/heaptuple.c,v 1.2 1996/08/13 01:32:26 scrappy Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* The old interface functions have been converted to macros`
`@@ -114,7 +114,7 @@ DataFill(char *data,`
`114`	`114`	`Datum value[],`
`115`	`115`	`char nulls[],`
`116`	`116`	`char *infomask,`
`117`		`- bits8 bit[])`
	`117`	`+ bits8 *bit)`
`118`	`118`	`{`
`119`	`119`	`bits8 *bitP;`
`120`	`120`	`int bitmask;`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`*`
`7`	`7`	`* Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`		`- * $Id: heapam.h,v 1.1.1.1 1996/07/09 06:21:08 scrappy Exp $`
	`9`	`+ * $Id: heapam.h,v 1.2 1996/08/13 01:32:17 scrappy Exp $`
`10`	`10`	`*`
`11`	`11`	`*-------------------------------------------------------------------------`
`12`	`12`	`*/`
`@@ -120,7 +120,7 @@ extern void heap_restrpos(HeapScanDesc sdesc);`
`120`	`120`	`extern Size ComputeDataSize(TupleDesc tupleDesc, Datum value[], char nulls[]);`
`121`	`121`	`extern void DataFill(char *data, TupleDesc tupleDesc,`
`122`	`122`	`Datum value[], char nulls[], char *infomask,`
`123`		`- bits8 bit[]);`
	`123`	`+ bits8 *bit);`
`124`	`124`	`extern int heap_attisnull(HeapTuple tup, int attnum);`
`125`	`125`	`extern int heap_sysattrlen(AttrNumber attno);`
`126`	`126`	`extern bool heap_sysattrbyval(AttrNumber attno);`