Skip to content

Commit a03c0d9

Browse files
committed
Code review for CLUSTER ALL patch. Fix bogus locking, incorrect transaction
stop/start nesting, other infelicities.
1 parent 2e1f2c3 commit a03c0d9

File tree

6 files changed

+286
-288
lines changed

6 files changed

+286
-288
lines changed

doc/src/sgml/ref/cluster.sgml

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!--
2-
$Header: /cvsroot/pgsql/doc/src/sgml/ref/cluster.sgml,v 1.22 2002/11/18 17:12:06 momjian Exp $
2+
$Header: /cvsroot/pgsql/doc/src/sgml/ref/cluster.sgml,v 1.23 2002/12/30 18:42:12 tgl Exp $
33
PostgreSQL documentation
44
-->
55

@@ -108,14 +108,16 @@ CLUSTER
108108

109109
<para>
110110
When a table is clustered, <productname>PostgreSQL</productname>
111-
remembers on which index it was clustered. In calls to
111+
remembers on which index it was clustered. The form
112112
<command>CLUSTER <replaceable class="parameter">tablename</replaceable></command>,
113-
the table is clustered on the same index that it was clustered before.
113+
re-clusters the table on the same index that it was clustered before.
114114
</para>
115115

116116
<para>
117-
A simple <command>CLUSTER</command> clusters all the tables in the database
118-
that the calling user owns and uses the saved cluster information. This
117+
<command>CLUSTER</command> without any parameter re-clusters all the tables
118+
in the
119+
current database that the calling user owns, or all tables if called
120+
by a superuser. (Never-clustered tables are not touched.) This
119121
form of <command>CLUSTER</command> cannot be called from inside a
120122
transaction or function.
121123
</para>
@@ -157,15 +159,15 @@ CLUSTER
157159
</para>
158160

159161
<para>
160-
<command>CLUSTER</command> preserves GRANT, inheritance, index, foreign
161-
key, and other ancillary information about the table.
162+
<command>CLUSTER</command> preserves GRANT, inheritance, index, foreign
163+
key, and other ancillary information about the table.
162164
</para>
163165

164166
<para>
165-
Because <command>CLUSTER</command> remembers the clustering information,
166-
one can cluster the tables one wants clustered manually the first time, and
167-
setup a timed event similar to <command>VACUUM</command> so that the tables
168-
are periodically and automatically clustered.
167+
Because <command>CLUSTER</command> remembers the clustering information,
168+
one can cluster the tables one wants clustered manually the first time, and
169+
setup a timed event similar to <command>VACUUM</command> so that the tables
170+
are periodically re-clustered.
169171
</para>
170172

171173
<para>

0 commit comments

Comments
 (0)