Fix under-parenthesized macro definitions

alvherre · alvherre · commit a0a40f611e9a · 2019-09-13T16:26:55.000-03:00
Lack of parens in the definitions could cause a statement using these macros to have unexpected semantics. In current code no bug is apparent, but best to fix the definitions to avoid problems down the line. Reported-by: Tom Lane Discussion: https://postgr.es/m/19795.1568400476@sss.pgh.pa.us
diff --git a/src/include/nodes/parsenodes.h b/src/include/nodes/parsenodes.h
@@ -3300,8 +3300,8 @@ typedef struct ConstraintsSetStmt
  */
 
 /* Reindex options */
-#define REINDEXOPT_VERBOSE 1 << 0	/* print progress info */
-#define REINDEXOPT_REPORT_PROGRESS 1 << 1	/* report pgstat progress */
+#define REINDEXOPT_VERBOSE (1 << 0)	/* print progress info */
+#define REINDEXOPT_REPORT_PROGRESS (1 << 1)	/* report pgstat progress */
 
 typedef enum ReindexObjectType
 {

Original file line number	Diff line number	Diff line change
`@@ -3300,8 +3300,8 @@ typedef struct ConstraintsSetStmt`
`3300`	`3300`	`*/`
`3301`	`3301`
`3302`	`3302`	`/* Reindex options */`
`3303`		`-#define REINDEXOPT_VERBOSE 1 << 0 /* print progress info */`
`3304`		`-#define REINDEXOPT_REPORT_PROGRESS 1 << 1 /* report pgstat progress */`
	`3303`	`+#define REINDEXOPT_VERBOSE (1 << 0) /* print progress info */`
	`3304`	`+#define REINDEXOPT_REPORT_PROGRESS (1 << 1) /* report pgstat progress */`
`3305`	`3305`
`3306`	`3306`	`typedef enum ReindexObjectType`
`3307`	`3307`	`{`