Don't use gethostbyname2(). It's not portable and we don't claim to

petere · petere · commit a11ea5e2a3bc · 2002-09-05T18:27:13.000Z
support IPv6 anyway.
diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c
@@ -11,7 +11,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-secure.c,v 1.11 2002/09/04 20:31:47 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-secure.c,v 1.12 2002/09/05 18:27:13 petere Exp $
  *
  * NOTES
  *	  The client *requires* a valid server certificate.  Since
@@ -364,7 +364,7 @@ verify_cb(int ok, X509_STORE_CTX *ctx)
 
 /*
  *	Verify that common name resolves to peer.
- *	This function is not thread-safe due to gethostbyname2().
+ *	This function is not thread-safe due to gethostbyname().
  */
 static int
 verify_peer(PGconn *conn)
@@ -391,7 +391,7 @@ verify_peer(PGconn *conn)
 		return 0;
 
 	/* what do we know about the peer's common name? */
-	if ((h = gethostbyname2(conn->peer_cn, addr.sa_family)) == NULL)
+	if ((h = gethostbyname(conn->peer_cn)) == NULL)
 	{
 		printfPQExpBuffer(&conn->errorMessage,
 		libpq_gettext("error getting information about host (%s): %s\n"),

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`*`
`12`	`12`	`*`
`13`	`13`	`* IDENTIFICATION`
`14`		`- * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-secure.c,v 1.11 2002/09/04 20:31:47 momjian Exp $`
	`14`	`+ * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-secure.c,v 1.12 2002/09/05 18:27:13 petere Exp $`
`15`	`15`	`*`
`16`	`16`	`* NOTES`
`17`	`17`	`* The client requires a valid server certificate. Since`
`@@ -364,7 +364,7 @@ verify_cb(int ok, X509_STORE_CTX *ctx)`
`364`	`364`
`365`	`365`	`/*`
`366`	`366`	`* Verify that common name resolves to peer.`
`367`		`- * This function is not thread-safe due to gethostbyname2().`
	`367`	`+ * This function is not thread-safe due to gethostbyname().`
`368`	`368`	`*/`
`369`	`369`	`static int`
`370`	`370`	`verify_peer(PGconn *conn)`
`@@ -391,7 +391,7 @@ verify_peer(PGconn *conn)`
`391`	`391`	`return 0;`
`392`	`392`
`393`	`393`	`/* what do we know about the peer's common name? */`
`394`		`- if ((h = gethostbyname2(conn->peer_cn, addr.sa_family)) == NULL)`
	`394`	`+ if ((h = gethostbyname(conn->peer_cn)) == NULL)`
`395`	`395`	`{`
`396`	`396`	`printfPQExpBuffer(&conn->errorMessage,`
`397`	`397`	`libpq_gettext("error getting information about host (%s): %s\n"),`