Correct off-by-one when reading from pipe

sfrost · sfrost · commit a3957ac156da · 2013-07-15T10:48:08.000-04:00
In pg_basebackup.c:reached_end_position(), we're reading from an
internal pipe with our own background process but we're possibly
reading more bytes than will actually fit into our buffer due to
an off-by-one error.  As we're reading from an internal pipe
there's no real risk here, but it's good form to not depend on
such convenient arrangements.

Bug spotted by the Coverity scanner.

Back-patch to 9.2 where this showed up.
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -166,7 +166,7 @@ reached_end_position(XLogRecPtr segendpos, uint32 timeline,
 			char		xlogend[64];
 
 			MemSet(xlogend, 0, sizeof(xlogend));
-			r = read(bgpipe[0], xlogend, sizeof(xlogend));
+			r = read(bgpipe[0], xlogend, sizeof(xlogend)-1);
 			if (r < 0)
 			{
 				fprintf(stderr, _("%s: could not read from ready pipe: %s\n"),

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ reached_end_position(XLogRecPtr segendpos, uint32 timeline,`
`166`	`166`	`char xlogend[64];`
`167`	`167`
`168`	`168`	`MemSet(xlogend, 0, sizeof(xlogend));`
`169`		`- r = read(bgpipe[0], xlogend, sizeof(xlogend));`
	`169`	`+ r = read(bgpipe[0], xlogend, sizeof(xlogend)-1);`
`170`	`170`	`if (r < 0)`
`171`	`171`	`{`
`172`	`172`	`fprintf(stderr, _("%s: could not read from ready pipe: %s\n"),`