Skip to content

Commit a51df14

Browse files
scrappyscrappy
committed
From: "Martin J. Laubach" <mjl@CSlab.tuwien.ac.at>
Subject: [HACKERS] Patch: SET var TO 'val' Here is a patch that adds a "SET variable TO 'somevalue'" capability to the parser, and then calls the SetPGVariable() function (which does just issue a elog(NOTICE) to see whether it works). That's the framework for adding timezone/date format/language/... stuff.
1 parent 17b5bd3 commit a51df14

File tree

5 files changed

+59
-9
lines changed

5 files changed

+59
-9
lines changed

‎src/backend/parser/gram.y

Lines changed: 29 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*
1111
*
1212
* IDENTIFICATION
13-
* $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 1.28 1997/04/02 04:01:03 vadim Exp $
13+
* $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 1.29 1997/04/02 18:23:07 scrappy Exp $
1414
*
1515
* HISTORY
1616
* AUTHOR DATE MAJOR EVENT
@@ -108,11 +108,12 @@ static Node *makeA_Expr(int oper, char *opname, Node *lexpr, Node *rexpr);
108108
RevokeStmt, RuleStmt, TransactionStmt, ViewStmt, LoadStmt,
109109
CreatedbStmt, DestroydbStmt, VacuumStmt, RetrieveStmt, CursorStmt,
110110
ReplaceStmt, AppendStmt, NotifyStmt, DeleteStmt, ClusterStmt,
111-
ExplainStmt
111+
ExplainStmt, VariableSetStmt
112112

113113
%type <str> relation_name, copy_file_name, copy_delimiter, def_name,
114114
database_name, access_method_clause, access_method, attr_name,
115-
class, index_name, var_name, name, file_name, recipe_name
115+
class, index_name, var_name, name, file_name, recipe_name,
116+
var_name
116117

117118
%type <str> opt_id, opt_portal_name,
118119
before_clause, after_clause, all_Op, MathOp, opt_name, opt_unique,
@@ -168,7 +169,7 @@ static Node *makeA_Expr(int oper, char *opname, Node *lexpr, Node *rexpr);
168169

169170
%type <ival> Iconst
170171
%type <str> Sconst
171-
%type <str> Id, date
172+
%type <str> Id, date, var_value
172173

173174

174175
/*
@@ -273,6 +274,30 @@ stmt : AddAttrStmt
273274
| CreatedbStmt
274275
| DestroydbStmt
275276
| VacuumStmt
277+
| VariableSetStmt
278+
;
279+
280+
/*****************************************************************************
281+
*
282+
* Set PG internal variable
283+
* SET var_name TO 'var_value'
284+
*
285+
*****************************************************************************/
286+
287+
VariableSetStmt: SET var_name TO var_value
288+
{
289+
VariableSetStmt *n = makeNode(VariableSetStmt);
290+
n->name = $2;
291+
n->value = $4;
292+
293+
$$ = (Node *) n;
294+
}
295+
;
296+
297+
var_name: Id { $$ = $1; }
298+
;
299+
300+
var_value: Sconst { $$ = $1; }
276301
;
277302

278303
/*****************************************************************************

‎src/backend/tcop/utility.c

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
*
1010
*
1111
* IDENTIFICATION
12-
* $Header: /cvsroot/pgsql/src/backend/tcop/utility.c,v 1.13 1997/04/02 04:06:32 vadim Exp $
12+
* $Header: /cvsroot/pgsql/src/backend/tcop/utility.c,v 1.14 1997/04/02 18:23:34 scrappy Exp $
1313
*
1414
*-------------------------------------------------------------------------
1515
*/
@@ -44,6 +44,7 @@
4444
#include "rewrite/rewriteDefine.h"
4545
#include "tcop/tcopdebug.h"
4646
#include "tcop/dest.h"
47+
#include "tcop/variable.h"
4748
#include "tcop/utility.h"
4849
#include "fmgr.h" /* For load_file() */
4950

@@ -634,7 +635,17 @@ ProcessUtility(Node *parsetree,
634635
beginRecipe(stmt);
635636
}
636637
break;
637-
638+
639+
/* ********************************
640+
* set variable statements
641+
*********************************/
642+
case T_VariableSetStmt:
643+
{
644+
VariableSetStmt *n = (VariableSetStmt *) parsetree;
645+
SetPGVariable(n->name, n->value);
646+
commandTag = "SET_VARIABLE";
647+
}
648+
break;
638649

639650
/* ********************************
640651
* default

‎src/backend/tcop/variable.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
#include "postgres.h"
22
#include "tcop/variable.h"
33

4-
bool SetPGVariable(const char *varName, const char *value)
4+
bool SetPGVariable(const char *name, const char *value)
55
{
6+
elog(NOTICE, "Variable %s set to \"%s\"", name, value);
7+
68
return TRUE;
79
}
810

‎src/include/nodes/nodes.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*
77
* Copyright (c) 1994, Regents of the University of California
88
*
9-
* $Id: nodes.h,v 1.6 1997/04/02 03:34:44 vadim Exp $
9+
* $Id: nodes.h,v 1.7 1997/04/02 18:24:38 scrappy Exp $
1010
*
1111
*-------------------------------------------------------------------------
1212
*/
@@ -179,6 +179,7 @@ typedef enum NodeTag {
179179
T_VacuumStmt,
180180
T_ExplainStmt,
181181
T_CreateSeqStmt,
182+
T_VariableSetStmt,
182183

183184
T_A_Expr = 700,
184185
T_Attr,

‎src/include/nodes/parsenodes.h

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*
77
* Copyright (c) 1994, Regents of the University of California
88
*
9-
* $Id: parsenodes.h,v 1.11 1997/04/02 03:34:46 vadim Exp $
9+
* $Id: parsenodes.h,v 1.12 1997/04/02 18:24:52 scrappy Exp $
1010
*
1111
*-------------------------------------------------------------------------
1212
*/
@@ -423,6 +423,17 @@ typedef struct ExplainStmt {
423423
bool verbose; /* print plan info */
424424
} ExplainStmt;
425425

426+
/* ----------------------
427+
* Set Statement
428+
* ----------------------
429+
*/
430+
431+
typedef struct VariableSetStmt {
432+
NodeTag type;
433+
char *name;
434+
char *value;
435+
} VariableSetStmt;
436+
426437

427438
/*****************************************************************************
428439
* Optimizable Statements

0 commit comments

Comments
 (0)