Fix pg_truncate() on Windows.

macdice · macdice · commit af209b7893f4 · 2023-01-06T16:50:23.000+13:00
Commit 57faaf3 added pg_truncate(const char *path, off_t length), but "length" was ignored under WIN32 and the file was unconditionally truncated to 0. There was no live bug, since the only caller passes 0. Fix, and back-patch to 14 where the function arrived. Author: Justin Pryzby <pryzby@telsasoft.com> Discussion: https://postgr.es/m/20230106031652.GR3109%40telsasoft.com
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
@@ -642,7 +642,7 @@ pg_truncate(const char *path, off_t length)
 	fd = OpenTransientFile(path, O_RDWR | PG_BINARY);
 	if (fd >= 0)
 	{
-		ret = ftruncate(fd, 0);
+		ret = ftruncate(fd, length);
 		save_errno = errno;
 		CloseTransientFile(fd);
 		errno = save_errno;

Original file line number	Diff line number	Diff line change
`@@ -642,7 +642,7 @@ pg_truncate(const char *path, off_t length)`
`642`	`642`	`fd = OpenTransientFile(path, O_RDWR \| PG_BINARY);`
`643`	`643`	`if (fd >= 0)`
`644`	`644`	`{`
`645`		`- ret = ftruncate(fd, 0);`
	`645`	`+ ret = ftruncate(fd, length);`
`646`	`646`	`save_errno = errno;`
`647`	`647`	`CloseTransientFile(fd);`
`648`	`648`	`errno = save_errno;`