Update tuple size check.

bmomjian · bmomjian · commit b1444b093486 · 1999-07-03T01:56:16.000Z
diff --git a/src/backend/access/heap/hio.c b/src/backend/access/heap/hio.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Id: hio.c,v 1.21 1999/07/03 01:47:02 momjian Exp $
+ *	  $Id: hio.c,v 1.22 1999/07/03 01:56:16 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -162,10 +162,13 @@ RelationPutHeapTupleAtEnd(Relation relation, HeapTuple tuple)
 		pageHeader = (Page) BufferGetPage(buffer);
 		PageInit(pageHeader, BufferGetPageSize(buffer), 0);
 
-		if (len > PageGetFreeSpace(pageHeader) && len <= MaxTupleSize)
+		if (len > PageGetFreeSpace(pageHeader))
 			elog(ERROR, "Tuple is too big: size %d", len);
 	}
 
+	if (len > MaxTupleSize)
+		elog(ERROR, "Tuple is too big: size %d, max size %d", len, MaxTupleSize);
+
 	if (!relation->rd_myxactonly)
 		UnlockPage(relation, 0, ExclusiveLock);
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Id: hio.c,v 1.21 1999/07/03 01:47:02 momjian Exp $`
	`10`	`+ * $Id: hio.c,v 1.22 1999/07/03 01:56:16 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -162,10 +162,13 @@ RelationPutHeapTupleAtEnd(Relation relation, HeapTuple tuple)`
`162`	`162`	`pageHeader = (Page) BufferGetPage(buffer);`
`163`	`163`	`PageInit(pageHeader, BufferGetPageSize(buffer), 0);`
`164`	`164`
`165`		`- if (len > PageGetFreeSpace(pageHeader) && len <= MaxTupleSize)`
	`165`	`+ if (len > PageGetFreeSpace(pageHeader))`
`166`	`166`	`elog(ERROR, "Tuple is too big: size %d", len);`
`167`	`167`	`}`
`168`	`168`
	`169`	`+ if (len > MaxTupleSize)`
	`170`	`+ elog(ERROR, "Tuple is too big: size %d, max size %d", len, MaxTupleSize);`
	`171`	`+`
`169`	`172`	`if (!relation->rd_myxactonly)`
`170`	`173`	`UnlockPage(relation, 0, ExclusiveLock);`
`171`	`174`