Use appropriate wait event when sending data in the apply worker.

Amit Kapila · pull[bot] · commit b1f5b5b0ae0d · 2023-10-26T07:29:53.000Z
Currently, we reuse WAIT_EVENT_LOGICAL_PARALLEL_APPLY_STATE_CHANGE in the apply worker while sending data to the parallel apply worker via a shared memory queue. This is not appropriate as one won't be able to distinguish whether the worker is waiting for sending data or for the state change. To patch instead uses the wait event WAIT_EVENT_MQ_SEND which has been already used in blocking mode while sending data via a shared memory queue. Author: Hou Zhijie Reviewed-by: Kuroda Hayato, Amit Kapila Discussion: https://postgr.es/m/OS0PR01MB57161C680B22E4C591628EE994DA9@OS0PR01MB5716.jpnprd01.prod.outlook.com
diff --git a/src/backend/replication/logical/applyparallelworker.c b/src/backend/replication/logical/applyparallelworker.c
@@ -1181,8 +1181,7 @@ pa_send_data(ParallelApplyWorkerInfo *winfo, Size nbytes, const void *data)
 		/* Wait before retrying. */
 		rc = WaitLatch(MyLatch,
 					   WL_LATCH_SET | WL_TIMEOUT | WL_EXIT_ON_PM_DEATH,
-					   SHM_SEND_RETRY_INTERVAL_MS,
-					   WAIT_EVENT_LOGICAL_PARALLEL_APPLY_STATE_CHANGE);
+					   SHM_SEND_RETRY_INTERVAL_MS, WAIT_EVENT_MQ_SEND);
 
 		if (rc & WL_LATCH_SET)
 		{

Original file line number	Diff line number	Diff line change
`@@ -1181,8 +1181,7 @@ pa_send_data(ParallelApplyWorkerInfo winfo, Size nbytes, const void data)`
`1181`	`1181`	`/* Wait before retrying. */`
`1182`	`1182`	`rc = WaitLatch(MyLatch,`
`1183`	`1183`	`WL_LATCH_SET \| WL_TIMEOUT \| WL_EXIT_ON_PM_DEATH,`
`1184`		`- SHM_SEND_RETRY_INTERVAL_MS,`
`1185`		`- WAIT_EVENT_LOGICAL_PARALLEL_APPLY_STATE_CHANGE);`
	`1184`	`+ SHM_SEND_RETRY_INTERVAL_MS, WAIT_EVENT_MQ_SEND);`
`1186`	`1185`
`1187`	`1186`	`if (rc & WL_LATCH_SET)`
`1188`	`1187`	`{`