Prefer actual constants to pseudo-constants in equivalence class machinery.

tglsfdc · tglsfdc · commit b1f7ee9218f9 · 2012-10-26T14:19:55.000-04:00
generate_base_implied_equalities_const() should prefer plain Consts over
other em_is_const eclass members when choosing the "pivot" value that
all the other members will be equated to.  This makes it more likely that
the generated equalities will be useful in constraint-exclusion proofs.
Per report from Rushabh Lathia.
diff --git a/src/backend/optimizer/path/equivclass.c b/src/backend/optimizer/path/equivclass.c
@@ -611,15 +611,21 @@ generate_base_implied_equalities_const(PlannerInfo *root,
 		}
 	}
 
-	/* Find the constant member to use */
+	/*
+	 * Find the constant member to use.  We prefer an actual constant to
+	 * pseudo-constants (such as Params), because the constraint exclusion
+	 * machinery might be able to exclude relations on the basis of generated
+	 * "var = const" equalities, but "var = param" won't work for that.
+	 */
 	foreach(lc, ec->ec_members)
 	{
 		EquivalenceMember *cur_em = (EquivalenceMember *) lfirst(lc);
 
 		if (cur_em->em_is_const)
 		{
 			const_em = cur_em;
-			break;
+			if (IsA(cur_em->em_expr, Const))
+				break;
 		}
 	}
 	Assert(const_em != NULL);

Original file line number	Diff line number	Diff line change
`@@ -611,15 +611,21 @@ generate_base_implied_equalities_const(PlannerInfo *root,`
`611`	`611`	`}`
`612`	`612`	`}`
`613`	`613`
`614`		`- /* Find the constant member to use */`
	`614`	`+ /*`
	`615`	`+ * Find the constant member to use. We prefer an actual constant to`
	`616`	`+ * pseudo-constants (such as Params), because the constraint exclusion`
	`617`	`+ * machinery might be able to exclude relations on the basis of generated`
	`618`	`+ * "var = const" equalities, but "var = param" won't work for that.`
	`619`	`+ */`
`615`	`620`	`foreach(lc, ec->ec_members)`
`616`	`621`	`{`
`617`	`622`	`EquivalenceMember cur_em = (EquivalenceMember ) lfirst(lc);`
`618`	`623`
`619`	`624`	`if (cur_em->em_is_const)`
`620`	`625`	`{`
`621`	`626`	`const_em = cur_em;`
`622`		`- break;`
	`627`	`+ if (IsA(cur_em->em_expr, Const))`
	`628`	`+ break;`
`623`	`629`	`}`
`624`	`630`	`}`
`625`	`631`	`Assert(const_em != NULL);`