In initdb, defend against assignment of NULL values to not-null columns.

tglsfdc · tglsfdc · commit b74701043e39 · 2017-06-13T10:54:43.000-04:00
Previously, you could write _null_ in a BKI DATA line for a column that's
supposed to be NOT NULL and initdb would let it pass, probably breaking
subsequent accesses to the row.  No doubt the original coding overlooked
this simple sanity check because in the beginning we didn't have any way
to mark catalog columns NOT NULL at initdb time.
diff --git a/src/backend/bootstrap/bootstrap.c b/src/backend/bootstrap/bootstrap.c
@@ -843,6 +843,11 @@ InsertOneNull(int i)
 {
 	elog(DEBUG4, "inserting column %d NULL", i);
 	Assert(i >= 0 && i < MAXATTR);
+	if (boot_reldesc->rd_att->attrs[i]->attnotnull)
+		elog(ERROR,
+		"NULL value specified for not-null column \"%s\" of relation \"%s\"",
+			 NameStr(boot_reldesc->rd_att->attrs[i]->attname),
+			 RelationGetRelationName(boot_reldesc));
 	values[i] = PointerGetDatum(NULL);
 	Nulls[i] = true;
 }

Original file line number	Diff line number	Diff line change
`@@ -843,6 +843,11 @@ InsertOneNull(int i)`
`843`	`843`	`{`
`844`	`844`	`elog(DEBUG4, "inserting column %d NULL", i);`
`845`	`845`	`Assert(i >= 0 && i < MAXATTR);`
	`846`	`+ if (boot_reldesc->rd_att->attrs[i]->attnotnull)`
	`847`	`+ elog(ERROR,`
	`848`	`+ "NULL value specified for not-null column \"%s\" of relation \"%s\"",`
	`849`	`+ NameStr(boot_reldesc->rd_att->attrs[i]->attname),`
	`850`	`+ RelationGetRelationName(boot_reldesc));`
`846`	`851`	`values[i] = PointerGetDatum(NULL);`
`847`	`852`	`Nulls[i] = true;`
`848`	`853`	`}`