Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

petere · petere · commit b7b0314b80e9 · 2018-12-22T07:27:21.000+01:00
This has never been correct since this code was introduced.
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -3422,7 +3422,7 @@ create_xlog_or_symlink(void)
 			exit_nicely();
 		}
 #else
-		fprintf(stderr, _("%s: symlinks are not supported on this platform"));
+		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);
 		exit_nicely();
 #endif
 	}
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -2248,7 +2248,7 @@ main(int argc, char **argv)
 			exit(1);
 		}
 #else
-		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"));
+		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);
 		exit(1);
 #endif
 		free(linkloc);

Original file line number	Diff line number	Diff line change
`@@ -3422,7 +3422,7 @@ create_xlog_or_symlink(void)`
`3422`	`3422`	`exit_nicely();`
`3423`	`3423`	`}`
`3424`	`3424`	`#else`
`3425`		`- fprintf(stderr, _("%s: symlinks are not supported on this platform"));`
	`3425`	`+ fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);`
`3426`	`3426`	`exit_nicely();`
`3427`	`3427`	`#endif`
`3428`	`3428`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2248,7 +2248,7 @@ main(int argc, char **argv)`
`2248`	`2248`	`exit(1);`
`2249`	`2249`	`}`
`2250`	`2250`	`#else`
`2251`		`- fprintf(stderr, _("%s: symlinks are not supported on this platform\n"));`
	`2251`	`+ fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);`
`2252`	`2252`	`exit(1);`
`2253`	`2253`	`#endif`
`2254`	`2254`	`free(linkloc);`