Skip to content

Commit bd19ab2

Browse files
committed
Try to stabilize vacuum test.
As commits b700f96 and 3414099 did for the reloptions test, make sure VACUUM can always truncate the table as expected. Back-patch to 12, where vacuum_truncate arrived. Discussion: https://postgr.es/m/CAD21AoCNoWjYkdEtr%2BVDoF9v__V905AedKZ9iF%3DArgCtrbxZqw%40mail.gmail.com
1 parent 4553b96 commit bd19ab2

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/test/regress/expected/vacuum.out

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,19 +127,19 @@ VACUUM (INDEX_CLEANUP FALSE) vaccluster;
127127
VACUUM (INDEX_CLEANUP FALSE) vactst; -- index cleanup option is ignored if no indexes
128128
VACUUM (INDEX_CLEANUP FALSE, FREEZE TRUE) vaccluster;
129129
-- TRUNCATE option
130-
CREATE TABLE vac_truncate_test(i INT NOT NULL, j text)
130+
CREATE TEMP TABLE vac_truncate_test(i INT NOT NULL, j text)
131131
WITH (vacuum_truncate=true, autovacuum_enabled=false);
132132
INSERT INTO vac_truncate_test VALUES (1, NULL), (NULL, NULL);
133133
ERROR: null value in column "i" violates not-null constraint
134134
DETAIL: Failing row contains (null, null).
135-
VACUUM (TRUNCATE FALSE) vac_truncate_test;
135+
VACUUM (TRUNCATE FALSE, DISABLE_PAGE_SKIPPING) vac_truncate_test;
136136
SELECT pg_relation_size('vac_truncate_test') > 0;
137137
?column?
138138
----------
139139
t
140140
(1 row)
141141

142-
VACUUM vac_truncate_test;
142+
VACUUM (DISABLE_PAGE_SKIPPING) vac_truncate_test;
143143
SELECT pg_relation_size('vac_truncate_test') = 0;
144144
?column?
145145
----------

src/test/regress/sql/vacuum.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,12 @@ VACUUM (INDEX_CLEANUP FALSE) vactst; -- index cleanup option is ignored if no in
111111
VACUUM (INDEX_CLEANUP FALSE, FREEZE TRUE) vaccluster;
112112

113113
-- TRUNCATE option
114-
CREATE TABLE vac_truncate_test(i INT NOT NULL, j text)
114+
CREATE TEMP TABLE vac_truncate_test(i INT NOT NULL, j text)
115115
WITH (vacuum_truncate=true, autovacuum_enabled=false);
116116
INSERT INTO vac_truncate_test VALUES (1, NULL), (NULL, NULL);
117-
VACUUM (TRUNCATE FALSE) vac_truncate_test;
117+
VACUUM (TRUNCATE FALSE, DISABLE_PAGE_SKIPPING) vac_truncate_test;
118118
SELECT pg_relation_size('vac_truncate_test') > 0;
119-
VACUUM vac_truncate_test;
119+
VACUUM (DISABLE_PAGE_SKIPPING) vac_truncate_test;
120120
SELECT pg_relation_size('vac_truncate_test') = 0;
121121
VACUUM (TRUNCATE FALSE, FULL TRUE) vac_truncate_test;
122122
DROP TABLE vac_truncate_test;

0 commit comments

Comments
 (0)