Skip to content

Commit c21214f

Browse files
committed
Honor TMPDIR.
Add the script name to the tmp directory name. Move trap up now that the dir is more unique.
1 parent ed9e8f5 commit c21214f

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

contrib/findoidjoins/make_oidjoins_check

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
# Caution: you may need to use GNU awk.
1111
AWK=${AWK:-awk}
1212

13-
TMP="/tmp/$$"
13+
TMP="${TMPDIR:-/tmp}/make_oidjoins_check.$$"
14+
trap "rm -rf $TMP" 0 1 2 3 15
1415

1516
# Create a temporary directory with the proper permissions so no one can
1617
# intercept our temporary files and cause a security breach.
@@ -23,8 +24,6 @@ fi
2324
umask "$OMASK"
2425
unset OMASK
2526

26-
trap "rm -rf $TMP" 0 1 2 3 15
27-
2827
INPUTFILE="$TMP/a"
2928
DUPSFILE="$TMP/b"
3029
NONDUPSFILE="$TMP/c"

doc/TODO

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -250,12 +250,17 @@ Indexes
250250
order. Another method would be to sort heap ctids matching the index
251251
before accessing the heap rows.
252252

253-
* Use bitmaps to combine existing indexes [performance]
253+
* Allow the creation of bitmap indexes which can be quickly combined
254+
with other bitmap indexes
254255

255-
Bitmap indexes allow single indexed columns to be combined to
256-
dynamically create a composite index to match a specific query. Each
257-
index is a bitmap, and the bitmaps are AND'ed or OR'ed to be combined.
256+
Bitmap indexes index single columns and can be combined with other bitmap
257+
indexes to dynamically create a composite index to match a specific query.
258+
Each index is a bitmap, and the bitmaps are bitwise AND'ed or OR'ed to be
259+
combined.
258260

261+
* Allow non-bitmap indexes to be combined
262+
263+
Do loUse bitmaps to combine non-bitmap indexes
259264
* Allow use of indexes to search for NULLs
260265

261266
One solution is to create a partial index on an IS NULL expression.

0 commit comments

Comments
 (0)