MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS.

nmisch · nmisch · commit c34dd43f409e · 2020-06-07T16:27:18.000-07:00
Commit 7be5d8d surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch to 9.5 (all supported versions).
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
@@ -190,7 +190,7 @@ sub tap_check
 	  unless $config->{tap_tests};
 
 	my @flags;
-	foreach my $arg (0 .. scalar(@_))
+	foreach my $arg (0 .. scalar(@_) - 1)
 	{
 		next unless $_[$arg] =~ /^PROVE_FLAGS=(.*)/;
 		@flags = split(/\s+/, $1);

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ sub tap_check`
`190`	`190`	`unless $config->{tap_tests};`
`191`	`191`
`192`	`192`	`my @flags;`
`193`		`- foreach my $arg (0 .. scalar(@_))`
	`193`	`+ foreach my $arg (0 .. scalar(@_) - 1)`
`194`	`194`	`{`
`195`	`195`	`next unless $_[$arg] =~ /^PROVE_FLAGS=(.*)/;`
`196`	`196`	`@flags = split(/\s+/, $1);`