Narrow scope of critical section, per discussion 1/19/01.

tglsfdc · tglsfdc · commit c654c69c05b3 · 2001-01-23T23:32:45.000Z
diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/vacuum.c,v 1.184 2001/01/19 22:08:46 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/vacuum.c,v 1.185 2001/01/23 23:32:45 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1904,7 +1904,6 @@ failed to add item with len = %lu to page %u (free space %lu, nusd %u, noff %u)"
 
 			buf = ReadBuffer(onerel, vacpage->blkno);
 			LockBuffer(buf, BUFFER_LOCK_EXCLUSIVE);
-			START_CRIT_SECTION();
 			page = BufferGetPage(buf);
 			num_tuples = 0;
 			for (offnum = FirstOffsetNumber;
@@ -1932,6 +1931,7 @@ failed to add item with len = %lu to page %u (free space %lu, nusd %u, noff %u)"
 
 			}
 			Assert(vacpage->offsets_free == num_tuples);
+			START_CRIT_SECTION();
 			uncnt = PageRepairFragmentation(page, unused);
 			{
 				XLogRecPtr	recptr;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/commands/vacuum.c,v 1.184 2001/01/19 22:08:46 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/vacuum.c,v 1.185 2001/01/23 23:32:45 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1904,7 +1904,6 @@ failed to add item with len = %lu to page %u (free space %lu, nusd %u, noff %u)"`
`1904`	`1904`
`1905`	`1905`	`buf = ReadBuffer(onerel, vacpage->blkno);`
`1906`	`1906`	`LockBuffer(buf, BUFFER_LOCK_EXCLUSIVE);`
`1907`		`- START_CRIT_SECTION();`
`1908`	`1907`	`page = BufferGetPage(buf);`
`1909`	`1908`	`num_tuples = 0;`
`1910`	`1909`	`for (offnum = FirstOffsetNumber;`
`@@ -1932,6 +1931,7 @@ failed to add item with len = %lu to page %u (free space %lu, nusd %u, noff %u)"`
`1932`	`1931`
`1933`	`1932`	`}`
`1934`	`1933`	`Assert(vacpage->offsets_free == num_tuples);`
	`1934`	`+ START_CRIT_SECTION();`
`1935`	`1935`	`uncnt = PageRepairFragmentation(page, unused);`
`1936`	`1936`	`{`
`1937`	`1937`	`XLogRecPtr recptr;`