The actual segfault was caused by a double pfree(), but ISTM that

bmomjian · bmomjian · commit c78701697c04 · 2002-12-14T18:49:37.000Z
failing to find pg_hba.conf should be a fatal error anyway, so I
increased the priority of the elog() from LOG to FATAL and refactored
the code a little bit.

Neil Conway
diff --git a/src/backend/libpq/hba.c b/src/backend/libpq/hba.c
@@ -10,7 +10,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/libpq/hba.c,v 1.91 2002/12/11 22:17:11 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/libpq/hba.c,v 1.92 2002/12/14 18:49:37 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -845,16 +845,13 @@ load_hba(void)
 	file = AllocateFile(conf_file, "r");
 	if (file == NULL)
 	{
-		/* The open of the config file failed.	*/
-		elog(LOG, "load_hba: Unable to open authentication config file \"%s\": %m",
+		elog(FATAL,
+			 "load_hba: Unable to open authentication config file \"%s\": %m",
 			 conf_file);
-		pfree(conf_file);
-	}
-	else
-	{
-		hba_lines = tokenize_file(file);
-		FreeFile(file);
 	}
+
+	hba_lines = tokenize_file(file);
+	FreeFile(file);
 	pfree(conf_file);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`*`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $Header: /cvsroot/pgsql/src/backend/libpq/hba.c,v 1.91 2002/12/11 22:17:11 momjian Exp $`
	`13`	`+ * $Header: /cvsroot/pgsql/src/backend/libpq/hba.c,v 1.92 2002/12/14 18:49:37 momjian Exp $`
`14`	`14`	`*`
`15`	`15`	`*-------------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -845,16 +845,13 @@ load_hba(void)`
`845`	`845`	`file = AllocateFile(conf_file, "r");`
`846`	`846`	`if (file == NULL)`
`847`	`847`	`{`
`848`		`- /* The open of the config file failed. */`
`849`		`- elog(LOG, "load_hba: Unable to open authentication config file \"%s\": %m",`
	`848`	`+ elog(FATAL,`
	`849`	`+ "load_hba: Unable to open authentication config file \"%s\": %m",`
`850`	`850`	`conf_file);`
`851`		`- pfree(conf_file);`
`852`		`- }`
`853`		`- else`
`854`		`- {`
`855`		`- hba_lines = tokenize_file(file);`
`856`		`- FreeFile(file);`
`857`	`851`	`}`
	`852`	`+`
	`853`	`+ hba_lines = tokenize_file(file);`
	`854`	`+ FreeFile(file);`
`858`	`855`	`pfree(conf_file);`
`859`	`856`	`}`
`860`	`857`