Skip to content

Commit c8213aa

Browse files
tvondratvondra
committed
Rename the role in stats_ext to have regress_ prefix
Commit 5be8ce8 added a new role to the stats_ext regression suite, but the role name did not start with regress_ causing failures when running with ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS. Fixed by renaming the role to start with the expected regress_ prefix. Backpatch-through: 10, same as the new regression test Discussion: https://postgr.es/m/1F238937-7CC2-4703-A1B1-6DC225B8978A%40enterprisedb.com
1 parent 1fe1a04 commit c8213aa

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

‎src/test/regress/expected/stats_ext.out

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,16 @@ DROP TABLE ext_stats_test;
5555
CREATE TABLE ab1 (a INTEGER, b INTEGER, c INTEGER);
5656
CREATE STATISTICS IF NOT EXISTS ab1_a_b_stats ON a, b FROM ab1;
5757
COMMENT ON STATISTICS ab1_a_b_stats IS 'new comment';
58-
CREATE ROLE temp_role;
59-
SET SESSION AUTHORIZATION temp_role;
58+
CREATE ROLE regress_stats_ext;
59+
SET SESSION AUTHORIZATION regress_stats_ext;
6060
COMMENT ON STATISTICS ab1_a_b_stats IS 'changed comment';
6161
ERROR: must be owner of statistics object ab1_a_b_stats
6262
DROP STATISTICS ab1_a_b_stats;
6363
ERROR: must be owner of statistics object ab1_a_b_stats
6464
ALTER STATISTICS ab1_a_b_stats RENAME TO ab1_a_b_stats_new;
6565
ERROR: must be owner of statistics object ab1_a_b_stats
6666
RESET SESSION AUTHORIZATION;
67-
DROP ROLE temp_role;
67+
DROP ROLE regress_stats_ext;
6868
CREATE STATISTICS IF NOT EXISTS ab1_a_b_stats ON a, b FROM ab1;
6969
NOTICE: statistics object "ab1_a_b_stats" already exists, skipping
7070
DROP STATISTICS ab1_a_b_stats;

‎src/test/regress/sql/stats_ext.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,13 @@ DROP TABLE ext_stats_test;
4444
CREATE TABLE ab1 (a INTEGER, b INTEGER, c INTEGER);
4545
CREATE STATISTICS IF NOT EXISTS ab1_a_b_stats ON a, b FROM ab1;
4646
COMMENT ON STATISTICS ab1_a_b_stats IS 'new comment';
47-
CREATE ROLE temp_role;
48-
SET SESSION AUTHORIZATION temp_role;
47+
CREATE ROLE regress_stats_ext;
48+
SET SESSION AUTHORIZATION regress_stats_ext;
4949
COMMENT ON STATISTICS ab1_a_b_stats IS 'changed comment';
5050
DROP STATISTICS ab1_a_b_stats;
5151
ALTER STATISTICS ab1_a_b_stats RENAME TO ab1_a_b_stats_new;
5252
RESET SESSION AUTHORIZATION;
53-
DROP ROLE temp_role;
53+
DROP ROLE regress_stats_ext;
5454

5555
CREATE STATISTICS IF NOT EXISTS ab1_a_b_stats ON a, b FROM ab1;
5656
DROP STATISTICS ab1_a_b_stats;

0 commit comments

Comments
 (0)