Register llvm_shutdown using on_proc_exit, not before_shmem_exit.

danielgustafsson · danielgustafsson · commit c980eeddccac · 2023-11-17T11:47:13.000+01:00
This seems more correct, because other before_shmem_exit calls may expect the infrastructure that is needed to run queries and access the database to be working, and also because this cleanup has nothing to do with shared memory. This is a back-patch of bab1500. There were no known user-visible consequences to this, though, apart from what was previous fixed by commit 3036401 and back-patched as commit bcbc272 and commit f701368, so bab1500 was not no back-patched at the time. Bharath Rupireddy Discussion: http://postgr.es/m/CALj2ACWk7j4F2v2fxxYfrroOF=AdFNPr1WsV+AGtHAFQOqm_pw@mail.gmail.com Backpatch-through: 13, 12
diff --git a/src/backend/jit/llvm/llvmjit.c b/src/backend/jit/llvm/llvmjit.c
@@ -925,7 +925,7 @@ llvm_session_initialize(void)
 	}
 #endif							/* LLVM_VERSION_MAJOR > 11 */
 
-	before_shmem_exit(llvm_shutdown, 0);
+	on_proc_exit(llvm_shutdown, 0);
 
 	llvm_session_initialized = true;
 

Original file line number	Diff line number	Diff line change
`@@ -925,7 +925,7 @@ llvm_session_initialize(void)`
`925`	`925`	`}`
`926`	`926`	`#endif /* LLVM_VERSION_MAJOR > 11 */`
`927`	`927`
`928`		`- before_shmem_exit(llvm_shutdown, 0);`
	`928`	`+ on_proc_exit(llvm_shutdown, 0);`
`929`	`929`
`930`	`930`	`llvm_session_initialized = true;`
`931`	`931`