Fix bogus size calculation introduced by commit cc5f813.

tglsfdc · tglsfdc · commit cad22075bc2c · 2017-09-17T11:35:27.000-04:00
The elements of RecordCacheArray are TupleDesc, not TupleDesc *.
Those are actually the same size, so that this error is harmless,
but it's still wrong --- and it might bite us someday, if TupleDesc
ever became a struct, say.

Per Coverity.
diff --git a/src/backend/utils/cache/typcache.c b/src/backend/utils/cache/typcache.c
@@ -1386,7 +1386,7 @@ ensure_record_cache_typmod_slot_exists(int32 typmod)
 		RecordCacheArray = (TupleDesc *) repalloc(RecordCacheArray,
 												  newlen * sizeof(TupleDesc));
 		memset(RecordCacheArray + RecordCacheArrayLen, 0,
-			   (newlen - RecordCacheArrayLen) * sizeof(TupleDesc *));
+			   (newlen - RecordCacheArrayLen) * sizeof(TupleDesc));
 		RecordCacheArrayLen = newlen;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -1386,7 +1386,7 @@ ensure_record_cache_typmod_slot_exists(int32 typmod)`
`1386`	`1386`	`RecordCacheArray = (TupleDesc *) repalloc(RecordCacheArray,`
`1387`	`1387`	`newlen * sizeof(TupleDesc));`
`1388`	`1388`	`memset(RecordCacheArray + RecordCacheArrayLen, 0,`
`1389`		`- (newlen - RecordCacheArrayLen) * sizeof(TupleDesc *));`
	`1389`	`+ (newlen - RecordCacheArrayLen) * sizeof(TupleDesc));`
`1390`	`1390`	`RecordCacheArrayLen = newlen;`
`1391`	`1391`	`}`
`1392`	`1392`	`}`