Ensure Soundex difference() function handles empty input sanely.

tglsfdc · tglsfdc · commit ccd362325622 · 2023-05-16T10:53:42.000-04:00
fuzzystrmatch's difference() function assumes that _soundex() always initializes its output buffer fully. This was not so for the case of a string containing no alphabetic characters, resulting in unstable output and Valgrind complaints. Fix by using memset() to fill the whole buffer in the early-exit case. Also make some cosmetic improvements (I didn't care for the random switches between "instr[0]" and "*instr" notation). Report and diagnosis by Alexander Lakhin (bug #17935). Back-patch to all supported branches. Discussion: https://postgr.es/m/17935-b99316aa79c18513@postgresql.org
diff --git a/contrib/fuzzystrmatch/expected/fuzzystrmatch.out b/contrib/fuzzystrmatch/expected/fuzzystrmatch.out
@@ -23,6 +23,12 @@ SELECT soundex('Anne'), soundex('Margaret'), difference('Anne', 'Margaret');
  A500    | M626    |          0
 (1 row)
 
+SELECT soundex(''), difference('', '');
+ soundex | difference 
+---------+------------
+         |          4
+(1 row)
+
 SELECT levenshtein('GUMBO', 'GAMBOL');
  levenshtein 
 -------------
diff --git a/contrib/fuzzystrmatch/fuzzystrmatch.c b/contrib/fuzzystrmatch/fuzzystrmatch.c
@@ -727,16 +727,14 @@ _soundex(const char *instr, char *outstr)
 	AssertArg(instr);
 	AssertArg(outstr);
 
-	outstr[SOUNDEX_LEN] = '\0';
-
 	/* Skip leading non-alphabetic characters */
-	while (!isalpha((unsigned char) instr[0]) && instr[0])
+	while (*instr && !isalpha((unsigned char) *instr))
 		++instr;
 
-	/* No string left */
-	if (!instr[0])
+	/* If no string left, return all-zeroes buffer */
+	if (!*instr)
 	{
-		outstr[0] = (char) 0;
+		memset(outstr, '\0', SOUNDEX_LEN + 1);
 		return;
 	}
 
@@ -749,7 +747,7 @@ _soundex(const char *instr, char *outstr)
 		if (isalpha((unsigned char) *instr) &&
 			soundex_code(*instr) != soundex_code(*(instr - 1)))
 		{
-			*outstr = soundex_code(instr[0]);
+			*outstr = soundex_code(*instr);
 			if (*outstr != '0')
 			{
 				++outstr;
@@ -766,6 +764,9 @@ _soundex(const char *instr, char *outstr)
 		++outstr;
 		++count;
 	}
+
+	/* And null-terminate */
+	*outstr = '\0';
 }
 
 PG_FUNCTION_INFO_V1(difference);
diff --git a/contrib/fuzzystrmatch/sql/fuzzystrmatch.sql b/contrib/fuzzystrmatch/sql/fuzzystrmatch.sql
@@ -6,6 +6,7 @@ SELECT soundex('hello world!');
 SELECT soundex('Anne'), soundex('Ann'), difference('Anne', 'Ann');
 SELECT soundex('Anne'), soundex('Andrew'), difference('Anne', 'Andrew');
 SELECT soundex('Anne'), soundex('Margaret'), difference('Anne', 'Margaret');
+SELECT soundex(''), difference('', '');
 
 
 SELECT levenshtein('GUMBO', 'GAMBOL');

Original file line number	Diff line number	Diff line change
`@@ -727,16 +727,14 @@ _soundex(const char instr, char outstr)`
`727`	`727`	`AssertArg(instr);`
`728`	`728`	`AssertArg(outstr);`
`729`	`729`
`730`		`- outstr[SOUNDEX_LEN] = '\0';`
`731`		`-`
`732`	`730`	`/* Skip leading non-alphabetic characters */`
`733`		`- while (!isalpha((unsigned char) instr[0]) && instr[0])`
	`731`	`+ while (instr && !isalpha((unsigned char) instr))`
`734`	`732`	`++instr;`
`735`	`733`
`736`		`- /* No string left */`
`737`		`- if (!instr[0])`
	`734`	`+ /* If no string left, return all-zeroes buffer */`
	`735`	`+ if (!*instr)`
`738`	`736`	`{`
`739`		`- outstr[0] = (char) 0;`
	`737`	`+ memset(outstr, '\0', SOUNDEX_LEN + 1);`
`740`	`738`	`return;`
`741`	`739`	`}`
`742`	`740`
`@@ -749,7 +747,7 @@ _soundex(const char instr, char outstr)`
`749`	`747`	`if (isalpha((unsigned char) *instr) &&`
`750`	`748`	`soundex_code(instr) != soundex_code((instr - 1)))`
`751`	`749`	`{`
`752`		`- *outstr = soundex_code(instr[0]);`
	`750`	`+ outstr = soundex_code(instr);`
`753`	`751`	`if (*outstr != '0')`
`754`	`752`	`{`
`755`	`753`	`++outstr;`
`@@ -766,6 +764,9 @@ _soundex(const char instr, char outstr)`
`766`	`764`	`++outstr;`
`767`	`765`	`++count;`
`768`	`766`	`}`
	`767`	`+`
	`768`	`+ /* And null-terminate */`
	`769`	`+ *outstr = '\0';`
`769`	`770`	`}`
`770`	`771`
`771`	`772`	`PG_FUNCTION_INFO_V1(difference);`