Allow pg_upgrade to upgrade clusters that use exclusion contraints by

bmomjian · bmomjian · commit d1644d9c3110 · 2011-11-25T14:39:18.000-05:00
fixing pg_dump to properly preserve such indexes.

Backpatch to 9.1 and 9.0 (where the bug was introduced).
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -11204,7 +11204,7 @@ dumpConstraint(Archive *fout, ConstraintInfo *coninfo)
 			exit_nicely();
 		}
 
-		if (binary_upgrade && !coninfo->condef)
+		if (binary_upgrade)
 			binary_upgrade_set_relfilenodes(q, indxinfo->dobj.catId.oid, true);
 
 		appendPQExpBuffer(q, "ALTER TABLE ONLY %s\n",

Original file line number	Diff line number	Diff line change
`@@ -11204,7 +11204,7 @@ dumpConstraint(Archive fout, ConstraintInfo coninfo)`
`11204`	`11204`	`exit_nicely();`
`11205`	`11205`	`}`
`11206`	`11206`
`11207`		`- if (binary_upgrade && !coninfo->condef)`
	`11207`	`+ if (binary_upgrade)`
`11208`	`11208`	`binary_upgrade_set_relfilenodes(q, indxinfo->dobj.catId.oid, true);`
`11209`	`11209`
`11210`	`11210`	`appendPQExpBuffer(q, "ALTER TABLE ONLY %s\n",`