Avoid generating excess (and illegal) parentheses around an aliased JOIN

tglsfdc · tglsfdc · commit d4b49b4bd4fb · 2004-12-13T00:33:06.000Z
in prettyprint mode.  Andreas Pflug
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
@@ -3,7 +3,7 @@
  *				back to source text
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.186 2004/12/11 23:26:45 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.187 2004/12/13 00:33:06 tgl Exp $
  *
  *	  This software is copyrighted by Jan Wieck - Hamburg.
  *
@@ -3903,7 +3903,8 @@ get_from_clause_item(Node *jtnode, Query *query, deparse_context *context)
 		bool		need_paren_on_right;
 
 		need_paren_on_right = PRETTY_PAREN(context) &&
-			!IsA(j->rarg, RangeTblRef);
+			!IsA(j->rarg, RangeTblRef) && 
+			!(IsA(j->rarg, JoinExpr) && ((JoinExpr*) j->rarg)->alias != NULL);
 
 		if (!PRETTY_PAREN(context) || j->alias != NULL)
 			appendStringInfoChar(buf, '(');

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`* back to source text`
`4`	`4`	`*`
`5`	`5`	`* IDENTIFICATION`
`6`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.186 2004/12/11 23:26:45 tgl Exp $`
	`6`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.187 2004/12/13 00:33:06 tgl Exp $`
`7`	`7`	`*`
`8`	`8`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`9`	`9`	`*`
`@@ -3903,7 +3903,8 @@ get_from_clause_item(Node jtnode, Query query, deparse_context *context)`
`3903`	`3903`	`bool need_paren_on_right;`
`3904`	`3904`
`3905`	`3905`	`need_paren_on_right = PRETTY_PAREN(context) &&`
`3906`		`- !IsA(j->rarg, RangeTblRef);`
	`3906`	`+ !IsA(j->rarg, RangeTblRef) &&`
	`3907`	`+ !(IsA(j->rarg, JoinExpr) && ((JoinExpr*) j->rarg)->alias != NULL);`
`3907`	`3908`
`3908`	`3909`	`if (!PRETTY_PAREN(context) \|\| j->alias != NULL)`
`3909`	`3910`	`appendStringInfoChar(buf, '(');`