Fix one more place where we were expecting lcons() to be nondestructive

tglsfdc · tglsfdc · commit d5013ab50f65 · 2004-11-20T17:59:31.000Z
to the original List; per report from Sebastian BÎck.  I think this is
the last such bug --- I examined every lcons() call in the backend and
the rest seem OK --- but it's nervous-making that we're still finding
'em so many months after the List rewrite went in.
diff --git a/src/backend/rewrite/rewriteHandler.c b/src/backend/rewrite/rewriteHandler.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/rewrite/rewriteHandler.c,v 1.145 2004/11/06 17:46:35 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/rewrite/rewriteHandler.c,v 1.146 2004/11/20 17:59:31 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1267,6 +1267,8 @@ RewriteQuery(Query *parsetree, List *rewrite_events)
 					newstuff = RewriteQuery(pt, rewrite_events);
 					rewritten = list_concat(rewritten, newstuff);
 				}
+
+				rewrite_events = list_delete_first(rewrite_events);
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $PostgreSQL: pgsql/src/backend/rewrite/rewriteHandler.c,v 1.145 2004/11/06 17:46:35 tgl Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/rewrite/rewriteHandler.c,v 1.146 2004/11/20 17:59:31 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1267,6 +1267,8 @@ RewriteQuery(Query parsetree, List rewrite_events)`
`1267`	`1267`	`newstuff = RewriteQuery(pt, rewrite_events);`
`1268`	`1268`	`rewritten = list_concat(rewritten, newstuff);`
`1269`	`1269`	`}`
	`1270`	`+`
	`1271`	`+ rewrite_events = list_delete_first(rewrite_events);`
`1270`	`1272`	`}`
`1271`	`1273`	`}`
`1272`	`1274`