Fix platform-dependent failure introduced by recent to_char changes

tglsfdc · tglsfdc · commit d6f1aa976002 · 2003-04-02T02:33:52.000Z
(ye good olde uninitialized-local-variable).
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
@@ -1,7 +1,7 @@
 /* -----------------------------------------------------------------------
  * formatting.c
  *
- * $Header: /cvsroot/pgsql/src/backend/utils/adt/formatting.c,v 1.62 2003/03/27 17:10:55 momjian Exp $
+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/formatting.c,v 1.63 2003/04/02 02:33:52 tgl Exp $
  *
  *
  *	 Portions Copyright (c) 1999-2002, PostgreSQL Global Development Group
@@ -3844,6 +3844,8 @@ NUM_processor(FormatNode *node, NUMDesc *Num, char *inout, char *number,
 	NUMProc		_Np,
 			   *Np = &_Np;
 
+	MemSet(Np, 0, sizeof(NUMProc));
+
 	Np->Num = Num;
 	Np->type = type;
 	Np->number = number;
@@ -3891,7 +3893,9 @@ NUM_processor(FormatNode *node, NUMDesc *Num, char *inout, char *number,
 		if (IS_PLUS(Np->Num) || IS_MINUS(Np->Num))
 		{
 			if (IS_PLUS(Np->Num) && IS_MINUS(Np->Num)==FALSE)
-				Np->sign_wrote = FALSE;
+				Np->sign_wrote = FALSE;		/* need sign */
+			else
+				Np->sign_wrote = TRUE;		/* needn't sign */
 		}
 		else
 		{

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/* -----------------------------------------------------------------------`
`2`	`2`	`* formatting.c`
`3`	`3`	`*`
`4`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/formatting.c,v 1.62 2003/03/27 17:10:55 momjian Exp $`
	`4`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/formatting.c,v 1.63 2003/04/02 02:33:52 tgl Exp $`
`5`	`5`	`*`
`6`	`6`	`*`
`7`	`7`	`* Portions Copyright (c) 1999-2002, PostgreSQL Global Development Group`
`@@ -3844,6 +3844,8 @@ NUM_processor(FormatNode node, NUMDesc Num, char inout, char number,`
`3844`	`3844`	`NUMProc _Np,`
`3845`	`3845`	`*Np = &_Np;`
`3846`	`3846`
	`3847`	`+ MemSet(Np, 0, sizeof(NUMProc));`
	`3848`	`+`
`3847`	`3849`	`Np->Num = Num;`
`3848`	`3850`	`Np->type = type;`
`3849`	`3851`	`Np->number = number;`
`@@ -3891,7 +3893,9 @@ NUM_processor(FormatNode node, NUMDesc Num, char inout, char number,`
`3891`	`3893`	`if (IS_PLUS(Np->Num) \|\| IS_MINUS(Np->Num))`
`3892`	`3894`	`{`
`3893`	`3895`	`if (IS_PLUS(Np->Num) && IS_MINUS(Np->Num)==FALSE)`
`3894`		`- Np->sign_wrote = FALSE;`
	`3896`	`+ Np->sign_wrote = FALSE; /* need sign */`
	`3897`	`+ else`
	`3898`	`+ Np->sign_wrote = TRUE; /* needn't sign */`
`3895`	`3899`	`}`
`3896`	`3900`	`else`
`3897`	`3901`	`{`