Fix minor memory leak in pg_dump

michaelpq · michaelpq · commit d70c014624dd · 2020-04-15T15:56:43.000+09:00
A query used to read default ACL information from the catalogs did not free a set of PQExpBuffer. Oversight in commit e2090d9, so backpatch down to 9.6. Author: Jie Zhang Reviewed-by: Sawada Masahiko Discussion: https://postgr.es/m/05bcbc5857f948efa0b451b85a48ae10@G08CNEXMBPEKD06.g08.fujitsu.local Backpatch-through: 9.6
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -9463,6 +9463,11 @@ getDefaultACLs(Archive *fout, int *numDefaultACLs)
 						  racl_subquery->data,
 						  initacl_subquery->data,
 						  initracl_subquery->data);
+
+		destroyPQExpBuffer(acl_subquery);
+		destroyPQExpBuffer(racl_subquery);
+		destroyPQExpBuffer(initacl_subquery);
+		destroyPQExpBuffer(initracl_subquery);
 	}
 	else
 	{

Original file line number	Diff line number	Diff line change
`@@ -9463,6 +9463,11 @@ getDefaultACLs(Archive fout, int numDefaultACLs)`
`9463`	`9463`	`racl_subquery->data,`
`9464`	`9464`	`initacl_subquery->data,`
`9465`	`9465`	`initracl_subquery->data);`
	`9466`	`+`
	`9467`	`+ destroyPQExpBuffer(acl_subquery);`
	`9468`	`+ destroyPQExpBuffer(racl_subquery);`
	`9469`	`+ destroyPQExpBuffer(initacl_subquery);`
	`9470`	`+ destroyPQExpBuffer(initracl_subquery);`
`9466`	`9471`	`}`
`9467`	`9472`	`else`
`9468`	`9473`	`{`