Skip to content

Commit d86fb72

Browse files
committed
Fix name collision between concurrent regression tests.
Commit f5bcd39 introduced a test using a table named "circles" in inherit.sql. Unfortunately, the concurrently executed constraints test was already using that table name, so the parallel regression tests would sometimes fail. Rename table to dodge the problem. Per buildfarm.
1 parent 641054a commit d86fb72

File tree

2 files changed

+24
-24
lines changed

2 files changed

+24
-24
lines changed

src/test/regress/expected/inherit.out

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,41 +1009,41 @@ Has OIDs: no
10091009

10101010
DROP TABLE test_constraints_inh;
10111011
DROP TABLE test_constraints;
1012-
CREATE TABLE circles (
1012+
CREATE TABLE test_ex_constraints (
10131013
c circle,
10141014
EXCLUDE USING gist (c WITH &&)
10151015
);
1016-
NOTICE: CREATE TABLE / EXCLUDE will create implicit index "circles_c_excl" for table "circles"
1017-
CREATE TABLE circles_inh () INHERITS (circles);
1018-
\d+ circles
1019-
Table "public.circles"
1016+
NOTICE: CREATE TABLE / EXCLUDE will create implicit index "test_ex_constraints_c_excl" for table "test_ex_constraints"
1017+
CREATE TABLE test_ex_constraints_inh () INHERITS (test_ex_constraints);
1018+
\d+ test_ex_constraints
1019+
Table "public.test_ex_constraints"
10201020
Column | Type | Modifiers | Storage | Stats target | Description
10211021
--------+--------+-----------+---------+--------------+-------------
10221022
c | circle | | plain | |
10231023
Indexes:
1024-
"circles_c_excl" EXCLUDE USING gist (c WITH &&)
1025-
Child tables: circles_inh
1024+
"test_ex_constraints_c_excl" EXCLUDE USING gist (c WITH &&)
1025+
Child tables: test_ex_constraints_inh
10261026
Has OIDs: no
10271027

1028-
ALTER TABLE circles DROP CONSTRAINT circles_c_excl;
1029-
\d+ circles
1030-
Table "public.circles"
1028+
ALTER TABLE test_ex_constraints DROP CONSTRAINT test_ex_constraints_c_excl;
1029+
\d+ test_ex_constraints
1030+
Table "public.test_ex_constraints"
10311031
Column | Type | Modifiers | Storage | Stats target | Description
10321032
--------+--------+-----------+---------+--------------+-------------
10331033
c | circle | | plain | |
1034-
Child tables: circles_inh
1034+
Child tables: test_ex_constraints_inh
10351035
Has OIDs: no
10361036

1037-
\d+ circles_inh
1038-
Table "public.circles_inh"
1037+
\d+ test_ex_constraints_inh
1038+
Table "public.test_ex_constraints_inh"
10391039
Column | Type | Modifiers | Storage | Stats target | Description
10401040
--------+--------+-----------+---------+--------------+-------------
10411041
c | circle | | plain | |
1042-
Inherits: circles
1042+
Inherits: test_ex_constraints
10431043
Has OIDs: no
10441044

1045-
DROP TABLE circles_inh;
1046-
DROP TABLE circles;
1045+
DROP TABLE test_ex_constraints_inh;
1046+
DROP TABLE test_ex_constraints;
10471047
-- Test non-inheritable foreign key contraints
10481048
CREATE TABLE test_primary_constraints(id int PRIMARY KEY);
10491049
NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index "test_primary_constraints_pkey" for table "test_primary_constraints"

src/test/regress/sql/inherit.sql

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -302,17 +302,17 @@ ALTER TABLE ONLY test_constraints DROP CONSTRAINT test_constraints_val1_val2_key
302302
DROP TABLE test_constraints_inh;
303303
DROP TABLE test_constraints;
304304

305-
CREATE TABLE circles (
305+
CREATE TABLE test_ex_constraints (
306306
c circle,
307307
EXCLUDE USING gist (c WITH &&)
308308
);
309-
CREATE TABLE circles_inh () INHERITS (circles);
310-
\d+ circles
311-
ALTER TABLE circles DROP CONSTRAINT circles_c_excl;
312-
\d+ circles
313-
\d+ circles_inh
314-
DROP TABLE circles_inh;
315-
DROP TABLE circles;
309+
CREATE TABLE test_ex_constraints_inh () INHERITS (test_ex_constraints);
310+
\d+ test_ex_constraints
311+
ALTER TABLE test_ex_constraints DROP CONSTRAINT test_ex_constraints_c_excl;
312+
\d+ test_ex_constraints
313+
\d+ test_ex_constraints_inh
314+
DROP TABLE test_ex_constraints_inh;
315+
DROP TABLE test_ex_constraints;
316316

317317
-- Test non-inheritable foreign key contraints
318318
CREATE TABLE test_primary_constraints(id int PRIMARY KEY);

0 commit comments

Comments
 (0)