Skip to content

Commit d9110d7

Browse files
tglsfdctglsfdc
committed
Straighten out leakproofness markings on text comparison functions.
Since we introduced the idea of leakproof functions, texteq and textne were marked leakproof but their sibling text comparison functions were not. This inconsistency seemed justified because texteq/textne just relied on memcmp() and so could easily be seen to be leakproof, while the other comparison functions are far more complex and indeed can throw input-dependent errors. However, that argument crashed and burned with the addition of nondeterministic collations, because now texteq/textne may invoke the exact same varstr_cmp() infrastructure as the rest. It makes no sense whatever to give them different leakproofness markings. After a certain amount of angst we've concluded that it's all right to consider varstr_cmp() to be leakproof, mostly because the other choice would be disastrous for performance of many queries where leakproofness matters. The input-dependent errors should only be reachable for corrupt input data, or so we hope anyway; certainly, if they are reachable in practice, we've got problems with requirements as basic as maintaining a btree index on a text column. Hence, run around to all the SQL functions that derive from varstr_cmp() and mark them leakproof. This should result in a useful gain in flexibility/performance for queries in which non-leakproofness degrades the efficiency of the query plan. Back-patch to v12 where nondeterministic collations were added. While this isn't an essential bug fix given the determination that varstr_cmp() is leakproof, we might as well apply it now that we've been forced into a post-beta4 catversion bump. Discussion: https://postgr.es/m/31481.1568303470@sss.pgh.pa.us
1 parent d3c61e8 commit d9110d7

File tree

5 files changed

+115
-81
lines changed

5 files changed

+115
-81
lines changed

‎src/backend/utils/adt/varlena.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1463,6 +1463,12 @@ check_collation_set(Oid collid)
14631463
* to allow null-termination for inputs to strcoll().
14641464
* Returns an integer less than, equal to, or greater than zero, indicating
14651465
* whether arg1 is less than, equal to, or greater than arg2.
1466+
*
1467+
* Note: many functions that depend on this are marked leakproof; therefore,
1468+
* avoid reporting the actual contents of the input when throwing errors.
1469+
* All errors herein should be things that can't happen except on corrupt
1470+
* data, anyway; otherwise we will have trouble with indexing strings that
1471+
* would cause them.
14661472
*/
14671473
int
14681474
varstr_cmp(const char *arg1, int len1, const char *arg2, int len2, Oid collid)

‎src/include/catalog/catversion.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@
5353
*/
5454

5555
/* yyyymmddN */
56-
#define CATALOG_VERSION_NO 201909211
56+
#define CATALOG_VERSION_NO 201909212
5757

5858
#endif

‎src/include/catalog/pg_proc.dat

Lines changed: 66 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -681,44 +681,44 @@
681681
proname => 'nameeqtext', proleakproof => 't', prorettype => 'bool',
682682
proargtypes => 'name text', prosrc => 'nameeqtext' },
683683
{ oid => '241',
684-
proname => 'namelttext', prorettype => 'bool', proargtypes => 'name text',
685-
prosrc => 'namelttext' },
684+
proname => 'namelttext', proleakproof => 't', prorettype => 'bool',
685+
proargtypes => 'name text', prosrc => 'namelttext' },
686686
{ oid => '242',
687-
proname => 'nameletext', prorettype => 'bool', proargtypes => 'name text',
688-
prosrc => 'nameletext' },
687+
proname => 'nameletext', proleakproof => 't', prorettype => 'bool',
688+
proargtypes => 'name text', prosrc => 'nameletext' },
689689
{ oid => '243',
690-
proname => 'namegetext', prorettype => 'bool', proargtypes => 'name text',
691-
prosrc => 'namegetext' },
690+
proname => 'namegetext', proleakproof => 't', prorettype => 'bool',
691+
proargtypes => 'name text', prosrc => 'namegetext' },
692692
{ oid => '244',
693-
proname => 'namegttext', prorettype => 'bool', proargtypes => 'name text',
694-
prosrc => 'namegttext' },
693+
proname => 'namegttext', proleakproof => 't', prorettype => 'bool',
694+
proargtypes => 'name text', prosrc => 'namegttext' },
695695
{ oid => '245',
696696
proname => 'namenetext', proleakproof => 't', prorettype => 'bool',
697697
proargtypes => 'name text', prosrc => 'namenetext' },
698698
{ oid => '246', descr => 'less-equal-greater',
699-
proname => 'btnametextcmp', prorettype => 'int4', proargtypes => 'name text',
700-
prosrc => 'btnametextcmp' },
699+
proname => 'btnametextcmp', proleakproof => 't', prorettype => 'int4',
700+
proargtypes => 'name text', prosrc => 'btnametextcmp' },
701701
{ oid => '247',
702702
proname => 'texteqname', proleakproof => 't', prorettype => 'bool',
703703
proargtypes => 'text name', prosrc => 'texteqname' },
704704
{ oid => '248',
705-
proname => 'textltname', prorettype => 'bool', proargtypes => 'text name',
706-
prosrc => 'textltname' },
705+
proname => 'textltname', proleakproof => 't', prorettype => 'bool',
706+
proargtypes => 'text name', prosrc => 'textltname' },
707707
{ oid => '249',
708-
proname => 'textlename', prorettype => 'bool', proargtypes => 'text name',
709-
prosrc => 'textlename' },
708+
proname => 'textlename', proleakproof => 't', prorettype => 'bool',
709+
proargtypes => 'text name', prosrc => 'textlename' },
710710
{ oid => '250',
711-
proname => 'textgename', prorettype => 'bool', proargtypes => 'text name',
712-
prosrc => 'textgename' },
711+
proname => 'textgename', proleakproof => 't', prorettype => 'bool',
712+
proargtypes => 'text name', prosrc => 'textgename' },
713713
{ oid => '251',
714-
proname => 'textgtname', prorettype => 'bool', proargtypes => 'text name',
715-
prosrc => 'textgtname' },
714+
proname => 'textgtname', proleakproof => 't', prorettype => 'bool',
715+
proargtypes => 'text name', prosrc => 'textgtname' },
716716
{ oid => '252',
717717
proname => 'textnename', proleakproof => 't', prorettype => 'bool',
718718
proargtypes => 'text name', prosrc => 'textnename' },
719719
{ oid => '253', descr => 'less-equal-greater',
720-
proname => 'bttextnamecmp', prorettype => 'int4', proargtypes => 'text name',
721-
prosrc => 'bttextnamecmp' },
720+
proname => 'bttextnamecmp', proleakproof => 't', prorettype => 'int4',
721+
proargtypes => 'text name', prosrc => 'bttextnamecmp' },
722722

723723
{ oid => '266', descr => 'concatenate name and oid',
724724
proname => 'nameconcatoid', prorettype => 'name', proargtypes => 'name oid',
@@ -1002,14 +1002,14 @@
10021002
proname => 'btcharcmp', proleakproof => 't', prorettype => 'int4',
10031003
proargtypes => 'char char', prosrc => 'btcharcmp' },
10041004
{ oid => '359', descr => 'less-equal-greater',
1005-
proname => 'btnamecmp', prorettype => 'int4', proargtypes => 'name name',
1006-
prosrc => 'btnamecmp' },
1005+
proname => 'btnamecmp', proleakproof => 't', prorettype => 'int4',
1006+
proargtypes => 'name name', prosrc => 'btnamecmp' },
10071007
{ oid => '3135', descr => 'sort support',
10081008
proname => 'btnamesortsupport', prorettype => 'void',
10091009
proargtypes => 'internal', prosrc => 'btnamesortsupport' },
10101010
{ oid => '360', descr => 'less-equal-greater',
1011-
proname => 'bttextcmp', prorettype => 'int4', proargtypes => 'text text',
1012-
prosrc => 'bttextcmp' },
1011+
proname => 'bttextcmp', proleakproof => 't', prorettype => 'int4',
1012+
proargtypes => 'text text', prosrc => 'bttextcmp' },
10131013
{ oid => '3255', descr => 'sort support',
10141014
proname => 'bttextsortsupport', prorettype => 'void',
10151015
proargtypes => 'internal', prosrc => 'bttextsortsupport' },
@@ -1218,11 +1218,11 @@
12181218
proargmodes => '{v}', prosrc => 'pg_num_nonnulls' },
12191219

12201220
{ oid => '458', descr => 'larger of two',
1221-
proname => 'text_larger', prorettype => 'text', proargtypes => 'text text',
1222-
prosrc => 'text_larger' },
1221+
proname => 'text_larger', proleakproof => 't', prorettype => 'text',
1222+
proargtypes => 'text text', prosrc => 'text_larger' },
12231223
{ oid => '459', descr => 'smaller of two',
1224-
proname => 'text_smaller', prorettype => 'text', proargtypes => 'text text',
1225-
prosrc => 'text_smaller' },
1224+
proname => 'text_smaller', proleakproof => 't', prorettype => 'text',
1225+
proargtypes => 'text text', prosrc => 'text_smaller' },
12261226

12271227
{ oid => '460', descr => 'I/O',
12281228
proname => 'int8in', prorettype => 'int8', proargtypes => 'cstring',
@@ -1322,17 +1322,17 @@
13221322
prosrc => 'int28' },
13231323

13241324
{ oid => '655',
1325-
proname => 'namelt', prorettype => 'bool', proargtypes => 'name name',
1326-
prosrc => 'namelt' },
1325+
proname => 'namelt', proleakproof => 't', prorettype => 'bool',
1326+
proargtypes => 'name name', prosrc => 'namelt' },
13271327
{ oid => '656',
1328-
proname => 'namele', prorettype => 'bool', proargtypes => 'name name',
1329-
prosrc => 'namele' },
1328+
proname => 'namele', proleakproof => 't', prorettype => 'bool',
1329+
proargtypes => 'name name', prosrc => 'namele' },
13301330
{ oid => '657',
1331-
proname => 'namegt', prorettype => 'bool', proargtypes => 'name name',
1332-
prosrc => 'namegt' },
1331+
proname => 'namegt', proleakproof => 't', prorettype => 'bool',
1332+
proargtypes => 'name name', prosrc => 'namegt' },
13331333
{ oid => '658',
1334-
proname => 'namege', prorettype => 'bool', proargtypes => 'name name',
1335-
prosrc => 'namege' },
1334+
proname => 'namege', proleakproof => 't', prorettype => 'bool',
1335+
proargtypes => 'name name', prosrc => 'namege' },
13361336
{ oid => '659',
13371337
proname => 'namene', proleakproof => 't', prorettype => 'bool',
13381338
proargtypes => 'name name', prosrc => 'namene' },
@@ -1426,17 +1426,17 @@
14261426
proargtypes => 'circle point', prosrc => 'dist_cpoint' },
14271427

14281428
{ oid => '740',
1429-
proname => 'text_lt', prorettype => 'bool', proargtypes => 'text text',
1430-
prosrc => 'text_lt' },
1429+
proname => 'text_lt', proleakproof => 't', prorettype => 'bool',
1430+
proargtypes => 'text text', prosrc => 'text_lt' },
14311431
{ oid => '741',
1432-
proname => 'text_le', prorettype => 'bool', proargtypes => 'text text',
1433-
prosrc => 'text_le' },
1432+
proname => 'text_le', proleakproof => 't', prorettype => 'bool',
1433+
proargtypes => 'text text', prosrc => 'text_le' },
14341434
{ oid => '742',
1435-
proname => 'text_gt', prorettype => 'bool', proargtypes => 'text text',
1436-
prosrc => 'text_gt' },
1435+
proname => 'text_gt', proleakproof => 't', prorettype => 'bool',
1436+
proargtypes => 'text text', prosrc => 'text_gt' },
14371437
{ oid => '743',
1438-
proname => 'text_ge', prorettype => 'bool', proargtypes => 'text text',
1439-
prosrc => 'text_ge' },
1438+
proname => 'text_ge', proleakproof => 't', prorettype => 'bool',
1439+
proargtypes => 'text text', prosrc => 'text_ge' },
14401440

14411441
{ oid => '745', descr => 'current user name',
14421442
proname => 'current_user', provolatile => 's', prorettype => 'name',
@@ -2026,29 +2026,29 @@
20262026
proname => 'bpchareq', proleakproof => 't', prorettype => 'bool',
20272027
proargtypes => 'bpchar bpchar', prosrc => 'bpchareq' },
20282028
{ oid => '1049',
2029-
proname => 'bpcharlt', prorettype => 'bool', proargtypes => 'bpchar bpchar',
2030-
prosrc => 'bpcharlt' },
2029+
proname => 'bpcharlt', proleakproof => 't', prorettype => 'bool',
2030+
proargtypes => 'bpchar bpchar', prosrc => 'bpcharlt' },
20312031
{ oid => '1050',
2032-
proname => 'bpcharle', prorettype => 'bool', proargtypes => 'bpchar bpchar',
2033-
prosrc => 'bpcharle' },
2032+
proname => 'bpcharle', proleakproof => 't', prorettype => 'bool',
2033+
proargtypes => 'bpchar bpchar', prosrc => 'bpcharle' },
20342034
{ oid => '1051',
2035-
proname => 'bpchargt', prorettype => 'bool', proargtypes => 'bpchar bpchar',
2036-
prosrc => 'bpchargt' },
2035+
proname => 'bpchargt', proleakproof => 't', prorettype => 'bool',
2036+
proargtypes => 'bpchar bpchar', prosrc => 'bpchargt' },
20372037
{ oid => '1052',
2038-
proname => 'bpcharge', prorettype => 'bool', proargtypes => 'bpchar bpchar',
2039-
prosrc => 'bpcharge' },
2038+
proname => 'bpcharge', proleakproof => 't', prorettype => 'bool',
2039+
proargtypes => 'bpchar bpchar', prosrc => 'bpcharge' },
20402040
{ oid => '1053',
20412041
proname => 'bpcharne', proleakproof => 't', prorettype => 'bool',
20422042
proargtypes => 'bpchar bpchar', prosrc => 'bpcharne' },
20432043
{ oid => '1063', descr => 'larger of two',
2044-
proname => 'bpchar_larger', prorettype => 'bpchar',
2044+
proname => 'bpchar_larger', proleakproof => 't', prorettype => 'bpchar',
20452045
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_larger' },
20462046
{ oid => '1064', descr => 'smaller of two',
2047-
proname => 'bpchar_smaller', prorettype => 'bpchar',
2047+
proname => 'bpchar_smaller', proleakproof => 't', prorettype => 'bpchar',
20482048
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_smaller' },
20492049
{ oid => '1078', descr => 'less-equal-greater',
2050-
proname => 'bpcharcmp', prorettype => 'int4', proargtypes => 'bpchar bpchar',
2051-
prosrc => 'bpcharcmp' },
2050+
proname => 'bpcharcmp', proleakproof => 't', prorettype => 'int4',
2051+
proargtypes => 'bpchar bpchar', prosrc => 'bpcharcmp' },
20522052
{ oid => '3328', descr => 'sort support',
20532053
proname => 'bpchar_sortsupport', prorettype => 'void',
20542054
proargtypes => 'internal', prosrc => 'bpchar_sortsupport' },
@@ -6501,38 +6501,38 @@
65016501
proargtypes => 'float8 float8', prosrc => 'aggregate_dummy' },
65026502

65036503
{ oid => '2160',
6504-
proname => 'text_pattern_lt', prorettype => 'bool',
6504+
proname => 'text_pattern_lt', proleakproof => 't', prorettype => 'bool',
65056505
proargtypes => 'text text', prosrc => 'text_pattern_lt' },
65066506
{ oid => '2161',
6507-
proname => 'text_pattern_le', prorettype => 'bool',
6507+
proname => 'text_pattern_le', proleakproof => 't', prorettype => 'bool',
65086508
proargtypes => 'text text', prosrc => 'text_pattern_le' },
65096509
{ oid => '2163',
6510-
proname => 'text_pattern_ge', prorettype => 'bool',
6510+
proname => 'text_pattern_ge', proleakproof => 't', prorettype => 'bool',
65116511
proargtypes => 'text text', prosrc => 'text_pattern_ge' },
65126512
{ oid => '2164',
6513-
proname => 'text_pattern_gt', prorettype => 'bool',
6513+
proname => 'text_pattern_gt', proleakproof => 't', prorettype => 'bool',
65146514
proargtypes => 'text text', prosrc => 'text_pattern_gt' },
65156515
{ oid => '2166', descr => 'less-equal-greater',
6516-
proname => 'bttext_pattern_cmp', prorettype => 'int4',
6516+
proname => 'bttext_pattern_cmp', proleakproof => 't', prorettype => 'int4',
65176517
proargtypes => 'text text', prosrc => 'bttext_pattern_cmp' },
65186518
{ oid => '3332', descr => 'sort support',
65196519
proname => 'bttext_pattern_sortsupport', prorettype => 'void',
65206520
proargtypes => 'internal', prosrc => 'bttext_pattern_sortsupport' },
65216521

65226522
{ oid => '2174',
6523-
proname => 'bpchar_pattern_lt', prorettype => 'bool',
6523+
proname => 'bpchar_pattern_lt', proleakproof => 't', prorettype => 'bool',
65246524
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_pattern_lt' },
65256525
{ oid => '2175',
6526-
proname => 'bpchar_pattern_le', prorettype => 'bool',
6526+
proname => 'bpchar_pattern_le', proleakproof => 't', prorettype => 'bool',
65276527
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_pattern_le' },
65286528
{ oid => '2177',
6529-
proname => 'bpchar_pattern_ge', prorettype => 'bool',
6529+
proname => 'bpchar_pattern_ge', proleakproof => 't', prorettype => 'bool',
65306530
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_pattern_ge' },
65316531
{ oid => '2178',
6532-
proname => 'bpchar_pattern_gt', prorettype => 'bool',
6532+
proname => 'bpchar_pattern_gt', proleakproof => 't', prorettype => 'bool',
65336533
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_pattern_gt' },
65346534
{ oid => '2180', descr => 'less-equal-greater',
6535-
proname => 'btbpchar_pattern_cmp', prorettype => 'int4',
6535+
proname => 'btbpchar_pattern_cmp', proleakproof => 't', prorettype => 'int4',
65366536
proargtypes => 'bpchar bpchar', prosrc => 'btbpchar_pattern_cmp' },
65376537
{ oid => '3333', descr => 'sort support',
65386538
proname => 'btbpchar_pattern_sortsupport', prorettype => 'void',

‎src/test/regress/expected/opr_sanity.out

Lines changed: 42 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -526,9 +526,19 @@ int42ge(integer,smallint)
526526
oideq(oid,oid)
527527
oidne(oid,oid)
528528
nameeqtext(name,text)
529+
namelttext(name,text)
530+
nameletext(name,text)
531+
namegetext(name,text)
532+
namegttext(name,text)
529533
namenetext(name,text)
534+
btnametextcmp(name,text)
530535
texteqname(text,name)
536+
textltname(text,name)
537+
textlename(text,name)
538+
textgename(text,name)
539+
textgtname(text,name)
531540
textnename(text,name)
541+
bttextnamecmp(text,name)
532542
float4eq(real,real)
533543
float4ne(real,real)
534544
float4lt(real,real)
@@ -559,8 +569,12 @@ btfloat4cmp(real,real)
559569
btfloat8cmp(double precision,double precision)
560570
btoidcmp(oid,oid)
561571
btcharcmp("char","char")
572+
btnamecmp(name,name)
573+
bttextcmp(text,text)
562574
cash_cmp(money,money)
563575
btoidvectorcmp(oidvector,oidvector)
576+
text_larger(text,text)
577+
text_smaller(text,text)
564578
int8eq(bigint,bigint)
565579
int8ne(bigint,bigint)
566580
int8lt(bigint,bigint)
@@ -574,6 +588,10 @@ int84gt(bigint,integer)
574588
int84le(bigint,integer)
575589
int84ge(bigint,integer)
576590
oidvectorne(oidvector,oidvector)
591+
namelt(name,name)
592+
namele(name,name)
593+
namegt(name,name)
594+
namege(name,name)
577595
namene(name,name)
578596
oidvectorlt(oidvector,oidvector)
579597
oidvectorle(oidvector,oidvector)
@@ -582,6 +600,10 @@ oidvectorge(oidvector,oidvector)
582600
oidvectorgt(oidvector,oidvector)
583601
oidlt(oid,oid)
584602
oidle(oid,oid)
603+
text_lt(text,text)
604+
text_le(text,text)
605+
text_gt(text,text)
606+
text_ge(text,text)
585607
macaddr_eq(macaddr,macaddr)
586608
macaddr_lt(macaddr,macaddr)
587609
macaddr_le(macaddr,macaddr)
@@ -611,7 +633,14 @@ network_ne(inet,inet)
611633
network_cmp(inet,inet)
612634
lseg_eq(lseg,lseg)
613635
bpchareq(character,character)
636+
bpcharlt(character,character)
637+
bpcharle(character,character)
638+
bpchargt(character,character)
639+
bpcharge(character,character)
614640
bpcharne(character,character)
641+
bpchar_larger(character,character)
642+
bpchar_smaller(character,character)
643+
bpcharcmp(character,character)
615644
date_eq(date,date)
616645
date_lt(date,date)
617646
date_le(date,date)
@@ -707,6 +736,16 @@ timestamp_lt(timestamp without time zone,timestamp without time zone)
707736
timestamp_le(timestamp without time zone,timestamp without time zone)
708737
timestamp_ge(timestamp without time zone,timestamp without time zone)
709738
timestamp_gt(timestamp without time zone,timestamp without time zone)
739+
text_pattern_lt(text,text)
740+
text_pattern_le(text,text)
741+
text_pattern_ge(text,text)
742+
text_pattern_gt(text,text)
743+
bttext_pattern_cmp(text,text)
744+
bpchar_pattern_lt(character,character)
745+
bpchar_pattern_le(character,character)
746+
bpchar_pattern_ge(character,character)
747+
bpchar_pattern_gt(character,character)
748+
btbpchar_pattern_cmp(character,character)
710749
btint48cmp(integer,bigint)
711750
btint84cmp(bigint,integer)
712751
btint24cmp(smallint,integer)
@@ -1321,8 +1360,6 @@ WHERE o1.oprnegate = o2.oid AND p1.oid = o1.oprcode AND p2.oid = o2.oprcode AND
13211360

13221361
-- Btree comparison operators' functions should have the same volatility
13231362
-- and leakproofness markings as the associated comparison support function.
1324-
-- As of Postgres 12, the only exceptions are that textual equality functions
1325-
-- are marked leakproof but textual comparison/inequality functions are not.
13261363
SELECT pp.oid::regprocedure as proc, pp.provolatile as vp, pp.proleakproof as lp,
13271364
po.oid::regprocedure as opr, po.provolatile as vo, po.proleakproof as lo
13281365
FROM pg_proc pp, pg_proc po, pg_operator o, pg_amproc ap, pg_amop ao
@@ -1335,16 +1372,9 @@ WHERE pp.oid = ap.amproc AND po.oid = o.oprcode AND o.oid = ao.amopopr AND
13351372
(pp.provolatile != po.provolatile OR
13361373
pp.proleakproof != po.proleakproof)
13371374
ORDER BY 1;
1338-
proc | vp | lp | opr | vo | lo
1339-
-------------------------------------------+----+----+-------------------------------+----+----
1340-
btnametextcmp(name,text) | i | f | nameeqtext(name,text) | i | t
1341-
bttextnamecmp(text,name) | i | f | texteqname(text,name) | i | t
1342-
btnamecmp(name,name) | i | f | nameeq(name,name) | i | t
1343-
bttextcmp(text,text) | i | f | texteq(text,text) | i | t
1344-
bpcharcmp(character,character) | i | f | bpchareq(character,character) | i | t
1345-
bttext_pattern_cmp(text,text) | i | f | texteq(text,text) | i | t
1346-
btbpchar_pattern_cmp(character,character) | i | f | bpchareq(character,character) | i | t
1347-
(7 rows)
1375+
proc | vp | lp | opr | vo | lo
1376+
------+----+----+-----+----+----
1377+
(0 rows)
13481378

13491379
-- **************** pg_aggregate ****************
13501380
-- Look for illegal values in pg_aggregate fields.

‎src/test/regress/sql/opr_sanity.sql

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -806,8 +806,6 @@ WHERE o1.oprnegate = o2.oid AND p1.oid = o1.oprcode AND p2.oid = o2.oprcode AND
806806

807807
-- Btree comparison operators' functions should have the same volatility
808808
-- and leakproofness markings as the associated comparison support function.
809-
-- As of Postgres 12, the only exceptions are that textual equality functions
810-
-- are marked leakproof but textual comparison/inequality functions are not.
811809
SELECT pp.oid::regprocedure as proc, pp.provolatile as vp, pp.proleakproof as lp,
812810
po.oid::regprocedure as opr, po.provolatile as vo, po.proleakproof as lo
813811
FROM pg_proc pp, pg_proc po, pg_operator o, pg_amproc ap, pg_amop ao

0 commit comments

Comments
 (0)