Fix error status of vacuumdb when multiple jobs are used

michaelpq · michaelpq · commit db8802a99ed7 · 2019-05-09T10:29:40.000+09:00
When running a batch of VACUUM or ANALYZE commands on a given database, there were cases where it is possible to have vacuumdb not report an error where it actually should, leading to incorrect status results. Author: Julien Rouhaud Reviewed-by: Amit Kapila, Michael Paquier Discussion: https://postgr.es/m/CAOBaU_ZuTwz7CtqLYJ1Ouuh272bTQPLN8b1bAPk0bCBm4PDMTQ@mail.gmail.com Backpatch-through: 9.5
diff --git a/src/bin/scripts/vacuumdb.c b/src/bin/scripts/vacuumdb.c
@@ -525,7 +525,10 @@ vacuum_one_database(const char *dbname, vacuumingOptions *vacopts,
 		for (j = 0; j < concurrentCons; j++)
 		{
 			if (!GetQueryResult((slots + j)->connection, progname))
+			{
+				failed = true;
 				goto finish;
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -525,7 +525,10 @@ vacuum_one_database(const char dbname, vacuumingOptions vacopts,`
`525`	`525`	`for (j = 0; j < concurrentCons; j++)`
`526`	`526`	`{`
`527`	`527`	`if (!GetQueryResult((slots + j)->connection, progname))`
	`528`	`+ {`
	`529`	`+ failed = true;`
`528`	`530`	`goto finish;`
	`531`	`+ }`
`529`	`532`	`}`
`530`	`533`	`}`
`531`	`534`