Fix brain fade in e530be2.

robertmhaas · pull[bot] · commit e06dd0c06c4a · 2023-02-12T13:53:02.000Z
The BoolGetDatum() call ended up in the wrong place. It should be applied when we, err, want to convert a bool to a datum. Thanks to Tom Lane for noticing this. Discussion: http://postgr.es/m/2511599.1658861964@sss.pgh.pa.us
diff --git a/src/backend/commands/user.c b/src/backend/commands/user.c
@@ -693,14 +693,14 @@ AlterRole(ParseState *pstate, AlterRoleStmt *stmt)
 	 */
 	if (dissuper)
 	{
-		bool	should_be_super = BoolGetDatum(boolVal(dissuper->arg));
+		bool	should_be_super = boolVal(dissuper->arg);
 
 		if (!should_be_super && roleid == BOOTSTRAP_SUPERUSERID)
 			ereport(ERROR,
 					(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
 					 errmsg("permission denied: bootstrap user must be superuser")));
 
-		new_record[Anum_pg_authid_rolsuper - 1] = should_be_super;
+		new_record[Anum_pg_authid_rolsuper - 1] = BoolGetDatum(should_be_super);
 		new_record_repl[Anum_pg_authid_rolsuper - 1] = true;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -693,14 +693,14 @@ AlterRole(ParseState pstate, AlterRoleStmt stmt)`
`693`	`693`	`*/`
`694`	`694`	`if (dissuper)`
`695`	`695`	`{`
`696`		`- bool should_be_super = BoolGetDatum(boolVal(dissuper->arg));`
	`696`	`+ bool should_be_super = boolVal(dissuper->arg);`
`697`	`697`
`698`	`698`	`if (!should_be_super && roleid == BOOTSTRAP_SUPERUSERID)`
`699`	`699`	`ereport(ERROR,`
`700`	`700`	`(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),`
`701`	`701`	`errmsg("permission denied: bootstrap user must be superuser")));`
`702`	`702`
`703`		`- new_record[Anum_pg_authid_rolsuper - 1] = should_be_super;`
	`703`	`+ new_record[Anum_pg_authid_rolsuper - 1] = BoolGetDatum(should_be_super);`
`704`	`704`	`new_record_repl[Anum_pg_authid_rolsuper - 1] = true;`
`705`	`705`	`}`
`706`	`706`