Fix assertion failure when running pgbench -s.

MasaoFujii · MasaoFujii · commit e5cfb8cbbe91 · 2019-11-07T16:32:37.000+09:00
If there is the WAL page that the continuation WAL record just fits within (i.e., the continuation record ends just at the end of the page) and the LSN in such page is specified with -s option, previously pg_waldump caused an assertion failure. The cause of this assertion failure was that XLogFindNextRecord() that pg_waldump -s calls mistakenly handled such special WAL page. This commit changes XLogFindNextRecord() so that it can handle such WAL page correctly. Back-patch to all supported versions. Author: Andrey Lepikhov Reviewed-by: Fujii Masao, Michael Paquier Discussion: https://postgr.es/m/99303554-5dd5-06e6-f943-b3005ccd6edd@postgrespro.ru
diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c
@@ -955,7 +955,7 @@ XLogFindNextRecord(XLogReaderState *state, XLogRecPtr RecPtr)
 			 *
 			 * Note that record headers are MAXALIGN'ed
 			 */
-			if (MAXALIGN(header->xlp_rem_len) > (XLOG_BLCKSZ - pageHeaderSize))
+			if (MAXALIGN(header->xlp_rem_len) >= (XLOG_BLCKSZ - pageHeaderSize))
 				tmpRecPtr = targetPagePtr + XLOG_BLCKSZ;
 			else
 			{

Original file line number	Diff line number	Diff line change
`@@ -955,7 +955,7 @@ XLogFindNextRecord(XLogReaderState *state, XLogRecPtr RecPtr)`
`955`	`955`	`*`
`956`	`956`	`* Note that record headers are MAXALIGN'ed`
`957`	`957`	`*/`
`958`		`- if (MAXALIGN(header->xlp_rem_len) > (XLOG_BLCKSZ - pageHeaderSize))`
	`958`	`+ if (MAXALIGN(header->xlp_rem_len) >= (XLOG_BLCKSZ - pageHeaderSize))`
`959`	`959`	`tmpRecPtr = targetPagePtr + XLOG_BLCKSZ;`
`960`	`960`	`else`
`961`	`961`	`{`