Plug memory leak

alvherre · alvherre · commit e69093070440 · 2022-07-13T12:10:03.000+02:00
Commit 054325c created a memory leak in PQsendQueryInternal in case an error occurs while sending the message. Repair. Backpatch to 14, like that commit. Reported by Coverity.
diff --git a/src/interfaces/libpq/fe-exec.c b/src/interfaces/libpq/fe-exec.c
@@ -1546,6 +1546,7 @@ PQsendQueryInternal(PGconn *conn, const char *query, bool newQuery)
 
 sendFailed:
 	pqRecycleCmdQueueEntry(conn, entry);
+	pqRecycleCmdQueueEntry(conn, entry2);
 	/* error message should be set up already */
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -1546,6 +1546,7 @@ PQsendQueryInternal(PGconn conn, const char query, bool newQuery)`
`1546`	`1546`
`1547`	`1547`	`sendFailed:`
`1548`	`1548`	`pqRecycleCmdQueueEntry(conn, entry);`
	`1549`	`+ pqRecycleCmdQueueEntry(conn, entry2);`
`1549`	`1550`	`/* error message should be set up already */`
`1550`	`1551`	`return 0;`
`1551`	`1552`	`}`