Skip to content

Commit e8d74aa

Browse files
tglsfdctglsfdc
committed
Reject system columns as elements of foreign keys.
Up through v11 it was sensible to use the "oid" system column as a foreign key column, but since that was removed there's no visible usefulness in making any of the remaining system columns a foreign key. Moreover, since the TupleTableSlot rewrites in v12, such cases actively fail because of implicit assumptions that only user columns appear in foreign keys. The lack of complaints about that seems like good evidence that no one is trying to do it. Hence, rather than trying to repair those assumptions (of which there are at least two, maybe more), let's just forbid the case up front. Per this patch, a system column in either the referenced or referencing side of a foreign key will draw this error; however, putting one in the referenced side would have failed later anyway, since we don't allow unique indexes to be made on system columns. Per bug #17877 from Alexander Lakhin. Back-patch to v12; the case still appears to work in v11, so we shouldn't break it there. Discussion: https://postgr.es/m/17877-4bcc658e33df6de1@postgresql.org
1 parent d0d92fe commit e8d74aa

File tree

3 files changed

+23
-10
lines changed

3 files changed

+23
-10
lines changed

‎src/backend/commands/tablecmds.c

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9954,6 +9954,11 @@ ATExecValidateConstraint(List **wqueue, Relation rel, char *constrName,
99549954
* transformColumnNameList - transform list of column names
99559955
*
99569956
* Lookup each name and return its attnum and type OID
9957+
*
9958+
* Note: the name of this function suggests that it's general-purpose,
9959+
* but actually it's only used to look up names appearing in foreign-key
9960+
* clauses. The error messages would need work to use it in other cases,
9961+
* and perhaps the validity checks as well.
99579962
*/
99589963
static int
99599964
transformColumnNameList(Oid relId, List *colList,
@@ -9967,20 +9972,26 @@ transformColumnNameList(Oid relId, List *colList,
99679972
{
99689973
char *attname = strVal(lfirst(l));
99699974
HeapTuple atttuple;
9975+
Form_pg_attribute attform;
99709976

99719977
atttuple = SearchSysCacheAttName(relId, attname);
99729978
if (!HeapTupleIsValid(atttuple))
99739979
ereport(ERROR,
99749980
(errcode(ERRCODE_UNDEFINED_COLUMN),
99759981
errmsg("column \"%s\" referenced in foreign key constraint does not exist",
99769982
attname)));
9983+
attform = (Form_pg_attribute) GETSTRUCT(atttuple);
9984+
if (attform->attnum < 0)
9985+
ereport(ERROR,
9986+
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
9987+
errmsg("system columns cannot be used in foreign keys")));
99779988
if (attnum >= INDEX_MAX_KEYS)
99789989
ereport(ERROR,
99799990
(errcode(ERRCODE_TOO_MANY_COLUMNS),
99809991
errmsg("cannot have more than %d keys in a foreign key",
99819992
INDEX_MAX_KEYS)));
9982-
attnums[attnum] = ((Form_pg_attribute) GETSTRUCT(atttuple))->attnum;
9983-
atttypids[attnum] = ((Form_pg_attribute) GETSTRUCT(atttuple))->atttypid;
9993+
attnums[attnum] = attform->attnum;
9994+
atttypids[attnum] = attform->atttypid;
99849995
ReleaseSysCache(atttuple);
99859996
attnum++;
99869997
}

‎src/test/regress/expected/foreign_key.out

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -757,15 +757,16 @@ SELECT * from FKTABLE;
757757

758758
DROP TABLE FKTABLE;
759759
DROP TABLE PKTABLE;
760-
CREATE TABLE PKTABLE (ptest1 int PRIMARY KEY);
760+
-- Test some invalid FK definitions
761+
CREATE TABLE PKTABLE (ptest1 int PRIMARY KEY, someoid oid);
761762
CREATE TABLE FKTABLE_FAIL1 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (ftest2) REFERENCES PKTABLE);
762763
ERROR: column "ftest2" referenced in foreign key constraint does not exist
763764
CREATE TABLE FKTABLE_FAIL2 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (ftest1) REFERENCES PKTABLE(ptest2));
764765
ERROR: column "ptest2" referenced in foreign key constraint does not exist
765-
DROP TABLE FKTABLE_FAIL1;
766-
ERROR: table "fktable_fail1" does not exist
767-
DROP TABLE FKTABLE_FAIL2;
768-
ERROR: table "fktable_fail2" does not exist
766+
CREATE TABLE FKTABLE_FAIL3 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (tableoid) REFERENCES PKTABLE(someoid));
767+
ERROR: system columns cannot be used in foreign keys
768+
CREATE TABLE FKTABLE_FAIL4 ( ftest1 oid, CONSTRAINT fkfail1 FOREIGN KEY (ftest1) REFERENCES PKTABLE(tableoid));
769+
ERROR: system columns cannot be used in foreign keys
769770
DROP TABLE PKTABLE;
770771
-- Test for referencing column number smaller than referenced constraint
771772
CREATE TABLE PKTABLE (ptest1 int, ptest2 int, UNIQUE(ptest1, ptest2));

‎src/test/regress/sql/foreign_key.sql

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -463,12 +463,13 @@ SELECT * from FKTABLE;
463463
DROP TABLE FKTABLE;
464464
DROP TABLE PKTABLE;
465465

466-
CREATE TABLE PKTABLE (ptest1 int PRIMARY KEY);
466+
-- Test some invalid FK definitions
467+
CREATE TABLE PKTABLE (ptest1 int PRIMARY KEY, someoid oid);
467468
CREATE TABLE FKTABLE_FAIL1 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (ftest2) REFERENCES PKTABLE);
468469
CREATE TABLE FKTABLE_FAIL2 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (ftest1) REFERENCES PKTABLE(ptest2));
470+
CREATE TABLE FKTABLE_FAIL3 ( ftest1 int, CONSTRAINT fkfail1 FOREIGN KEY (tableoid) REFERENCES PKTABLE(someoid));
471+
CREATE TABLE FKTABLE_FAIL4 ( ftest1 oid, CONSTRAINT fkfail1 FOREIGN KEY (ftest1) REFERENCES PKTABLE(tableoid));
469472

470-
DROP TABLE FKTABLE_FAIL1;
471-
DROP TABLE FKTABLE_FAIL2;
472473
DROP TABLE PKTABLE;
473474

474475
-- Test for referencing column number smaller than referenced constraint

0 commit comments

Comments
 (0)