Remove AggregateRelationId from recordExtObjInitPriv()

petere · pull[bot] · commit edb3c6ce378c · 2023-10-26T07:29:53.000Z
This was erroneous, because AggregateRelationId has no OID, so it cannot be part of an extension directly. (Aggregates are registered via pg_proc.) No harm in practice, but better to make it correct. Reviewed-by: Nathan Bossart <nathandbossart@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/504bc485-6bd6-dd1b-fe10-e7351aeb310d@enterprisedb.com
diff --git a/src/backend/catalog/aclchk.c b/src/backend/catalog/aclchk.c
@@ -4510,7 +4510,6 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)
 		ReleaseSysCache(tuple);
 	}
 	else if (classoid == AccessMethodRelationId ||
-			 classoid == AggregateRelationId ||
 			 classoid == CastRelationId ||
 			 classoid == CollationRelationId ||
 			 classoid == ConversionRelationId ||

Original file line number	Diff line number	Diff line change
`@@ -4510,7 +4510,6 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)`
`4510`	`4510`	`ReleaseSysCache(tuple);`
`4511`	`4511`	`}`
`4512`	`4512`	`else if (classoid == AccessMethodRelationId \|\|`
`4513`		`- classoid == AggregateRelationId \|\|`
`4514`	`4513`	`classoid == CastRelationId \|\|`
`4515`	`4514`	`classoid == CollationRelationId \|\|`
`4516`	`4515`	`classoid == ConversionRelationId \|\|`