Tolerate EINVAL when calling fsync() on a directory.

macdice · macdice · commit ede6b19624d1 · 2019-02-25T00:02:56.000+13:00
Previously, we tolerated EBADF as a way for the operating system to indicate that it doesn't support fsync() on a directory. Tolerate EINVAL too, for older versions of Linux CIFS. Bug #15636. Back-patch all the way. Reported-by: John Klann Discussion: https://postgr.es/m/15636-d380890dafd78fc6@postgresql.org
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
@@ -2944,7 +2944,7 @@ fsync_fname_ext(const char *fname, bool isdir, bool ignore_perm, int elevel)
 	 * Some OSes don't allow us to fsync directories at all, so we can ignore
 	 * those errors. Anything else needs to be logged.
 	 */
-	if (returncode != 0 && !(isdir && errno == EBADF))
+	if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL)))
 	{
 		int			save_errno;
 
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -696,7 +696,7 @@ fsync_fname_ext(const char *fname, bool isdir)
 	 * Some OSes don't allow us to fsync directories at all, so we can ignore
 	 * those errors. Anything else needs to be reported.
 	 */
-	if (returncode != 0 && !(isdir && errno == EBADF))
+	if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL)))
 		fprintf(stderr, _("%s: could not fsync file \"%s\": %s\n"),
 				progname, fname, strerror(errno));
 

Original file line number	Diff line number	Diff line change
`@@ -2944,7 +2944,7 @@ fsync_fname_ext(const char *fname, bool isdir, bool ignore_perm, int elevel)`
`2944`	`2944`	`* Some OSes don't allow us to fsync directories at all, so we can ignore`
`2945`	`2945`	`* those errors. Anything else needs to be logged.`
`2946`	`2946`	`*/`
`2947`		`- if (returncode != 0 && !(isdir && errno == EBADF))`
	`2947`	`+ if (returncode != 0 && !(isdir && (errno == EBADF \|\| errno == EINVAL)))`
`2948`	`2948`	`{`
`2949`	`2949`	`int save_errno;`
`2950`	`2950`