fsync backup_label after pg_start_backup()

simonat2ndQuadrant · simonat2ndQuadrant · commit efed8c0031db · 2012-08-07T16:21:49.000+01:00
Dave Kerr, backpatched by Simon Riggs
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -9093,7 +9093,8 @@ do_pg_start_backup(const char *backupidstr, bool fast, char **labelfile)
 						 errmsg("could not create file \"%s\": %m",
 								BACKUP_LABEL_FILE)));
 			fwrite(labelfbuf.data, labelfbuf.len, 1, fp);
-			if (fflush(fp) || ferror(fp) || FreeFile(fp))
+
+			if (fflush(fp) || ferror(fp) || pg_fsync(fileno(fp)) != 0 || FreeFile(fp))
 				ereport(ERROR,
 						(errcode_for_file_access(),
 						 errmsg("could not write file \"%s\": %m",
