Avoid integer overflow when LIMIT + OFFSET >= 2^63.

hlinnaka · hlinnaka · commit f00fbad6bd43 · 2011-08-02T11:30:38.000+03:00
This fixes bug #6139 reported by Hitoshi Harada.
diff --git a/src/backend/executor/nodeLimit.c b/src/backend/executor/nodeLimit.c
@@ -125,7 +125,7 @@ ExecLimit(LimitState *node)
 				 * the state machine state to record having done so.
 				 */
 				if (!node->noCount &&
-					node->position >= node->offset + node->count)
+					node->position - node->offset >= node->count)
 				{
 					node->lstate = LIMIT_WINDOWEND;
 					return NULL;

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ ExecLimit(LimitState *node)`
`125`	`125`	`* the state machine state to record having done so.`
`126`	`126`	`*/`
`127`	`127`	`if (!node->noCount &&`
`128`		`- node->position >= node->offset + node->count)`
	`128`	`+ node->position - node->offset >= node->count)`
`129`	`129`	`{`
`130`	`130`	`node->lstate = LIMIT_WINDOWEND;`
`131`	`131`	`return NULL;`