Remove the streaming files for incomplete xacts after restart.

Amit Kapila · pull[bot] · commit f0620894ee2e · 2024-05-14T00:43:58.000Z
After restart, we try to stream the changes for large transactions that were not sent before server crash and restart. However, we forget to send the abort message for such transactions. This leads to spurious streaming files on the subscriber which won't be cleaned till the apply worker or the subscriber server restarts. Reported-by: Dilip Kumar Author: Hou Zhijie Reviewed-by: Dilip Kumar and Amit Kapila Backpatch-through: 14 Discussion: https://postgr.es/m/OS0PR01MB5716A773F46768A1B75BE24394FB9@OS0PR01MB5716.jpnprd01.prod.outlook.com
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
@@ -2936,6 +2936,10 @@ ReorderBufferAbortOld(ReorderBuffer *rb, TransactionId oldestRunningXid)
 		{
 			elog(DEBUG2, "aborting old transaction %u", txn->xid);
 
+			/* Notify the remote node about the crash/immediate restart. */
+			if (rbtxn_is_streamed(txn))
+				rb->stream_abort(rb, txn, InvalidXLogRecPtr);
+
 			/* remove potential on-disk data, and deallocate this tx */
 			ReorderBufferCleanupTXN(rb, txn);
 		}

Original file line number	Diff line number	Diff line change
`@@ -2936,6 +2936,10 @@ ReorderBufferAbortOld(ReorderBuffer *rb, TransactionId oldestRunningXid)`
`2936`	`2936`	`{`
`2937`	`2937`	`elog(DEBUG2, "aborting old transaction %u", txn->xid);`
`2938`	`2938`
	`2939`	`+ /* Notify the remote node about the crash/immediate restart. */`
	`2940`	`+ if (rbtxn_is_streamed(txn))`
	`2941`	`+ rb->stream_abort(rb, txn, InvalidXLogRecPtr);`
	`2942`	`+`
`2939`	`2943`	`/* remove potential on-disk data, and deallocate this tx */`
`2940`	`2944`	`ReorderBufferCleanupTXN(rb, txn);`
`2941`	`2945`	`}`