Be sure to release proc->backendLock after SetupLockInTable() failure.

tglsfdc · tglsfdc · commit f0e3e05ddab7 · 2013-11-29T17:35:15.000-05:00
The various places that transferred fast-path locks to the main lock table
neglected to release the PGPROC's backendLock if SetupLockInTable failed
due to being out of shared memory.  In most cases this is no big deal since
ensuing error cleanup would release all held LWLocks anyway.  But there are
some hot-standby functions that don't consider failure of
FastPathTransferRelationLocks to be a hard error, and in those cases this
oversight could lead to system lockup.  For consistency, make all of these
places look the same as FastPathTransferRelationLocks.

Noted while looking for the cause of Dan Wood's bugs --- this wasn't it,
but it's a bug anyway.
diff --git a/src/backend/storage/lmgr/lock.c b/src/backend/storage/lmgr/lock.c
@@ -2467,6 +2467,7 @@ FastPathTransferRelationLocks(LockMethod lockMethodTable, const LOCKTAG *locktag
 				if (!proclock)
 				{
 					LWLockRelease(partitionLock);
+					LWLockRelease(proc->backendLock);
 					return false;
 				}
 				GrantLock(proclock->tag.myLock, proclock, lockmode);
@@ -2522,6 +2523,7 @@ FastPathGetRelationLockEntry(LOCALLOCK *locallock)
 		if (!proclock)
 		{
 			LWLockRelease(partitionLock);
+			LWLockRelease(MyProc->backendLock);
 			ereport(ERROR,
 					(errcode(ERRCODE_OUT_OF_MEMORY),
 					 errmsg("out of shared memory"),
@@ -4011,6 +4013,7 @@ VirtualXactLock(VirtualTransactionId vxid, bool wait)
 		if (!proclock)
 		{
 			LWLockRelease(partitionLock);
+			LWLockRelease(proc->backendLock);
 			ereport(ERROR,
 					(errcode(ERRCODE_OUT_OF_MEMORY),
 					 errmsg("out of shared memory"),

Original file line number	Diff line number	Diff line change
`@@ -2467,6 +2467,7 @@ FastPathTransferRelationLocks(LockMethod lockMethodTable, const LOCKTAG *locktag`
`2467`	`2467`	`if (!proclock)`
`2468`	`2468`	`{`
`2469`	`2469`	`LWLockRelease(partitionLock);`
	`2470`	`+ LWLockRelease(proc->backendLock);`
`2470`	`2471`	`return false;`
`2471`	`2472`	`}`
`2472`	`2473`	`GrantLock(proclock->tag.myLock, proclock, lockmode);`
`@@ -2522,6 +2523,7 @@ FastPathGetRelationLockEntry(LOCALLOCK *locallock)`
`2522`	`2523`	`if (!proclock)`
`2523`	`2524`	`{`
`2524`	`2525`	`LWLockRelease(partitionLock);`
	`2526`	`+ LWLockRelease(MyProc->backendLock);`
`2525`	`2527`	`ereport(ERROR,`
`2526`	`2528`	`(errcode(ERRCODE_OUT_OF_MEMORY),`
`2527`	`2529`	`errmsg("out of shared memory"),`
`@@ -4011,6 +4013,7 @@ VirtualXactLock(VirtualTransactionId vxid, bool wait)`
`4011`	`4013`	`if (!proclock)`
`4012`	`4014`	`{`
`4013`	`4015`	`LWLockRelease(partitionLock);`
	`4016`	`+ LWLockRelease(proc->backendLock);`
`4014`	`4017`	`ereport(ERROR,`
`4015`	`4018`	`(errcode(ERRCODE_OUT_OF_MEMORY),`
`4016`	`4019`	`errmsg("out of shared memory"),`